1189973 - Don't show magnifying glass on mobile pages

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Comment 1

[:Margaret Leibovic]

I assume that you mean you want to disable the zoom view on pages with a mobile viewport.

There was some discussion about this in bug 1186738, but it didn't reach a conclusion.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Mike, Domivinc, perhaps we can get some movement on this?

In my mind, this would move us a step closer to shipping this feature. I think it's a great starting point to negating a lot of the "annoyance" that comes from this feature "not showing up at the right times".

Comment 3

[Dominique Vincent [:domivinc]]

Anthony, could we wait for a conclusion of the discussion in bug 1186738?

But if you really want to move here, do you have some details (pages and touch positions in the pages) of the "annoyance" in mobile pages?
Did you test recently the original issue in about:downloads page ? On my device, it seems to work without "annoyance". Let me know if you find a touch position in the about:download page where the issue is still visible.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Dominique Vincent [:domivinc] from comment #3)
> Anthony, could we wait for a conclusion of the discussion in bug 1186738?
> 
> But if you really want to move here, do you have some details (pages and
> touch positions in the pages) of the "annoyance" in mobile pages?
> Did you test recently the original issue in about:downloads page ? On my
> device, it seems to work without "annoyance". Let me know if you find a
> touch position in the about:download page where the issue is still visible.

I think this is independent of bug 1186738.

For the time being, if mobile specific styles are being used, we could just not show the "zoomed view". This isn't perfect, but it's a better starting point than either annoying users with this feature because they (most of the time) don't need it, or trying to formulate some sort of "one-size-fits-all" logic.

Comment 5

[Dominique Vincent [:domivinc]]

(In reply to Anthony Lam (:antlam) from comment #4)
> (In reply to Dominique Vincent [:domivinc] from comment #3)
> > Anthony, could we wait for a conclusion of the discussion in bug 1186738?
> > 
> > But if you really want to move here, do you have some details (pages and
> > touch positions in the pages) of the "annoyance" in mobile pages?
> > Did you test recently the original issue in about:downloads page ? On my
> > device, it seems to work without "annoyance". Let me know if you find a
> > touch position in the about:download page where the issue is still visible.
> 
> I think this is independent of bug 1186738.
> 
No, it's not independent, read comment 1.
The general discussion about this issue is in bug 1186738.
Feel free to mark this bug as a "duplicated" and update the title of bug 1186738.

> For the time being, if mobile specific styles are being used, we could just
> not show the "zoomed view". This isn't perfect, but it's a better starting
> point than either annoying users with this feature because they (most of the
> time) don't need it, or trying to formulate some sort of "one-size-fits-all"
> logic.

Please Anthony, could you clarify this point and give your definition of "mobile specific styles"?
I will make a prototype based on your definition.

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Dominique Vincent [:domivinc] from comment #5)
> > For the time being, if mobile specific styles are being used, we could just
> > not show the "zoomed view". This isn't perfect, but it's a better starting
> > point than either annoying users with this feature because they (most of the
> > time) don't need it, or trying to formulate some sort of "one-size-fits-all"
> > logic.
> 
> Please Anthony, could you clarify this point and give your definition of
> "mobile specific styles"?
> I will make a prototype based on your definition.

If the page calls a @media query for a smaller device/screen size

Comment 7

[Dominique Vincent [:domivinc]]

Michael, with the rules in comment 1 (page with a mobile viewport) and in comment 6 (@media query for a smaller device/screen size), the zoomed view will never be displayed. The number of sites without this kind of ccs rules are probably very limited, no ? In this case, it would be equivalent to not ship the zoomed view.

Two additional points to take into account:
- I still don't get the answers for the questions in comment 3. On your side ,do you have more details about the "annoyance" that comes from this feature? I really need details about the problems in order to fix them, it's hard to work to a fix just based on a general feeling.
- Bug 1191041 will limit the number of cases where the zoomed view will be displayed.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Dominique Vincent [:domivinc] from comment #7)
> Michael, with the rules in comment 1 (page with a mobile viewport) and in
> comment 6 (@media query for a smaller device/screen size), the zoomed view
> will never be displayed. The number of sites without this kind of ccs rules
> are probably very limited, no ?

I think these pages are limited, yes, but they're the ones that need it most as they're not designed for mobile.

>  In this case, it would be equivalent to not ship the zoomed view.

I disagree – we're trying to ship a base implementation which we can gradually improve the UX of and thus open to more sites (including mobile pages). We're trying to take the conservative approach for now so users don't turn it off and never see the improvements (or worse – uninstall!). Does that make sense?

> - Bug 1191041 will limit the number of cases where the zoomed view will be
> displayed.

To avoid changing too many variables at once, we can try fixing bug 1191041, seeing how the UX feels and if it still appears too frequently, we can try fixing this mobile page bug as well.

> - I still don't get the answers for the questions in comment 3. On your side
> ,do you have more details about the "annoyance" that comes from this
> feature? I really need details about the problems in order to fix them, it's
> hard to work to a fix just based on a general feeling.

The "annoyance", in my interpretation, is when the view appears and the user doesn't feel like it's necessary ("I clicked that link and there are no other links around!"). I think the message has been, "It appears to frequently and it's annoying!" when really it's a combination of many other edge case bugs (e.g. bug 1191041, bug 1190332). Perhaps we should try to change only one "when does the view appear" variable at a time to see how the overall feel of the zoomed view changes and then choose where to make more progress from there.

Sorry for not being more specific but I personally find it very hard to be because it's hard to describe something that's no very reproducible given varying device sizes, inconsistent finger presses, etc. NI us again when bug 1191041 is fixed and we'll see what could use some improvements and we'll try to be concrete about it.

Let me know what you think.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Like bug 1186738 comment 19, for correctness sake, it's better not to have the special case. Also, it's arguable whether it should show up on mobile pages (e.g. poorly designed pages may necessitate it) so closed.

We can reopen this if it becomes a problem while riding the trains.