[Aries][Homescreen] Handle/lines at top of groups are off enter in edit mode

VERIFIED FIXED

Status

Firefox OS
Gaia::Homescreen
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: AdamA, Assigned: cwiiis)

Tracking

(Blocks: 1 bug, {polish})

unspecified
ARM
Gonk (Firefox OS)
polish

Firefox Tracking Flags

(b2g-master verified)

Details

(Whiteboard: [2.5-Daily-Testing][Spark][Systemsfe])

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
Created attachment 8641948 [details]
logcat

Description:
In edit mode there are lines at the top of uncompressed groups. These handles are not centered on the screen in aries devices. On flame devices these handles are centered in the middle of the screen.

Repro Steps:
1) Update a Aries to 20150731163020
2) Long press on an icon on the homescreen to enter edit mode
3) Observe Handles at top of groups

Actual:
The handles are not centered in the middle of the screen

Expected:
It is expected that the handles are centered

Environmental Variables:
Device: Aries 2.5 [Full Flash]
Build ID: 20150731163020
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Screenshot, logcat
(Reporter)

Comment 1

3 years ago
Created attachment 8641950 [details]
Handles not centered Aries
(Reporter)

Comment 2

3 years ago
This issue DOES NOT occur on Flame 2.5.

Environmental Variables:
Device: Flame 2.5 [Full Flash]
BuildID: 20150731030207
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Result:
The handles at the top of groups is centered
Blocks: 1171119
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-master: --- → affected
Flags: needinfo?(ktucker)
Whiteboard: [2.5-Daily-Testing][Spark][Systemsfe]
This doesn't seem to really break anything so not nominating to block on this.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
(Assignee)

Comment 4

3 years ago
I'll take a look at this when I have a spare moment.
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Keywords: polish
Created attachment 8662968 [details] [review]
[gaia] Cwiiis:bug1189994-verticalhome-gripper-off-center > mozilla-b2g:master
(Assignee)

Comment 6

3 years ago
Comment on attachment 8662968 [details] [review]
[gaia] Cwiiis:bug1189994-verticalhome-gripper-off-center > mozilla-b2g:master

Just a 1-line CSS fix.
Attachment #8662968 - Flags: review?(kevingrandon)
Comment on attachment 8662968 [details] [review]
[gaia] Cwiiis:bug1189994-verticalhome-gripper-off-center > mozilla-b2g:master

Seems fine to me, thanks.
Attachment #8662968 - Flags: review?(kevingrandon) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/201f4de082d846d615a03aff5c1b997a52014cc7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
This bug has been verified as "pass" on the latest Aires KK 2.5 by the STR in comment 0.

Actual results: The handles are centered in the middle of the screen on editing mode of homescreen.
See attachment: verified_Aries_v2.5.png
Reproduce rate: 0/10


Device: Aries KK 2.5 (Pass)
Build ID               20150920050928
Gaia Revision          e67d319d0854e32e23210784eb9c4e1b8a025adb
Gaia Date              2015-09-19 07:42:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/ccd6b5f5e544c1d708849144943a776941bd3794
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150920.042926
Firmware Date          Sun Sep 20 04:29:33 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][MGSEI-Triage+]
status-b2g-master: affected → verified
Created attachment 8663489 [details]
verified_Aries_v2.5.png
You need to log in before you can comment on or make changes to this bug.