Closed
Bug 1190012
Opened 9 years ago
Closed 5 years ago
gdata unit tests are not failing correctly
Categories
(Calendar :: Provider: GData, defect)
Calendar
Provider: GData
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: Fallen, Unassigned)
Details
There is something seriously messed up with the xpcshell tests. The gdata tests are passing without trouble (if the remaining build works), but there is an obvious mistake:
https://dxr.mozilla.org/comm-central/source/calendar/test/unit/test_gdata_provider.js#472
The function creates dt but never returns it. Also, just equal() should fail there since deepEqual() is required, and Services.prefs.getCharPref() might throw because the timezone is not set. resetTo() with an invalid timezone should throw NS_ERROR_UNEXPECTED.
When running this on my machine, I also got dateToJSON is not defined for some reason, they only way to fix that was to import into an object instead of the global.
Even with making seemingly unnecesary code changes, I couldn't get the whole test to fully pass, the last I got was:
Unexpected exception 3253927937
undefined
exiting test
Reporter | ||
Comment 1•9 years ago
|
||
Update: I have a fix for the dateToJSON test, but the tests accessing the fakeserver are also failing hard. At the second getClient call, the sync hangs somewhere during the async copying of the response of the last http request.
Reporter | ||
Comment 2•9 years ago
|
||
Next update, I've gotten almost all tests running locally. I needed to reset the fakeserver after each request, if more than a few requests are made then the test hangs.
I'm still having errors every few test runs, therefore I started a try run to see if it is just my machine.
Reporter | ||
Comment 3•9 years ago
|
||
Ok, this is a waste of time. I'm giving up for now. Latest try build here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=892457c7638a
Reporter | ||
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•