1190023 - Tab sound icon shows on pages with <video muted>

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Reuben Morais [:reuben]]

STR:

1) Open a tab with a <video muted>, like this one: http://i.imgur.com/96apNsd.gifv

Result: Sound icon shows up.

Expected results: No sound icon.

Comment 2

[(no longer active)]

While this is fixed by bug 1190040, I would like to have a separate test for it.

Comment 3

[(no longer active)]

Attachment: Add a test to ensure that muted media elements do not dispatch media-playback

Comment 4

[Jesse Ruderman]

Does your patch also fix the problem for media muted using the context menu?

Comment 5

[(no longer active)]

(In reply to Jesse Ruderman from comment #4)
> Does your patch also fix the problem for media muted using the context menu?

No, I filed that as bug 1190924.

Comment 6

[(no longer active)]

Comment on attachment 8642040 [details] [diff] [review]
Add a test to ensure that muted media elements do not dispatch media-playback

This test is buggy since it doesn't wait for the loadedmetadata event, and therefore we have no audio track, and it passes because of the HasAudio() check...

Comment 8

[(no longer active)]

Attachment: Ensure that muting a media element dispatches the media-playback event, and also include the muted state in computing whether a media element is actively playing audio

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8643289 [details] [diff] [review]
Ensure that muting a media element dispatches the media-playback event, and also include the muted state in computing whether a media element is actively playing audio

Review of attachment 8643289 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLMediaElement.cpp
@@ +4467,5 @@
>      return;
>    }
>  
>    bool playingThroughTheAudioChannel =
> +     (!mPaused && !Muted() &&

What about if something sets the volume to 0? Do you want to not display the "playing audio" indicator then? If so you could check Volume() != 0 (possibly fuzzily; it's a float), and call UpdateAudioChannelPlayingState() in SetVolumeInternal().

Comment 10

[(no longer active)]

That is a good idea, I'll do that.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0e2077727c9

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0e2077727c9

Comment 13

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150813124640).