1190029 - Would like a way to see which groups are 'secure' groups in editusers.cgi when diagnosing password reset issues

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[David Lawrence [:dkl]]

Maybe put a symbol or word (secure) next to each secure group to show which ones the user belongs to.

Comment 1

[Gervase Markham [:gerv]]

By "secure", do you mean "not allowed to log in using non-BMO auth"?

Gerv

Comment 2

[David Lawrence [:dkl]]

Just simply placing a secure tag next to each group in the list of possible groups stating which ones are marked as "SecureMail" enabled groups. More of a convenience for me and my workflow. May be useful for others as well. Basically showing that if I add a person to that group, they will need to have their email clients configured properly to do password resets, etc.

Comment 3

[David Lawrence [:dkl]]

Attachment: 1190029_1.patch

Comment 5

[:glob ✱]

Comment on attachment 8642081 [details] [diff] [review]
1190029_1.patch

Review of attachment 8642081 [details] [diff] [review]:
-----------------------------------------------------------------

from the earlier bug: there should be 2 indicators: one for 'has provided public key', and another for 'is member of group which requires encryption'.

::: extensions/SecureMail/Extension.pm
@@ +227,5 @@
>          }
>      }
> +    elsif ($file eq 'admin/users/edit.html.tmpl') {
> +        $vars->{secure_mail_groups}
> +            = Bugzilla::Group->match({ isactive => 1, secure_mail => 1 });

nit: no need to wrap this line

::: extensions/SecureMail/template/en/default/hook/global/header-start.html.tmpl
@@ +13,5 @@
> +  %]
> +  <script type="text/javascript">
> +    var eu_secure_mail_groups = [];
> +    [% FOREACH group = secure_mail_groups %]
> +    eu_secure_mail_groups.push('[% group.id FILTER js %]');

this line needs indentation

::: extensions/SecureMail/web/js/edit_user.js
@@ +8,5 @@
> +
> +$(function() {
> +    'use strict';
> +    $(document).ready(function() {
> +        if (typeof eu_secure_mail_groups != 'undefined') {

when will eu_secure_mail_groups be undefined?  as far as i can tell it's always defined but may be empty.

@@ +11,5 @@
> +    $(document).ready(function() {
> +        if (typeof eu_secure_mail_groups != 'undefined') {
> +            for (var i = 0, l = eu_secure_mail_groups.length; i < l; i++) {
> +                $("label[for='group_" + eu_secure_mail_groups[i] + "']")
> +                    .append(' <span class=\"eu_secure_mail_group\">(secure mail)</span>');

nit: no need to escape the " characters there

Comment 6

[David Lawrence [:dkl]]

Attachment: 1190029_2.patch

Thanks for the view and sorry missed the earlier bug which is related to this enhancement. Here is a revised patch that has also been simplified from my earlier version.

dkl

Comment 7

[:glob ✱]

Comment on attachment 8643779 [details] [diff] [review]
1190029_2.patch

Review of attachment 8643779 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with the fixes on commit please.

::: extensions/SecureMail/template/en/default/hook/admin/users/userdata-end.html.tmpl
@@ +6,5 @@
> +  # defined by the Mozilla Public License, v. 2.0.
> +  #%]
> +
> +<tr>
> +  <th>Has SecureMail Key/Cert:</th>

SecureMail should be two words - "Secure Mail"

@@ +9,5 @@
> +<tr>
> +  <th>Has SecureMail Key/Cert:</th>
> +  <td>
> +    [% IF user.public_key %]
> +      <span style="color:blue;">YES</span>

as this information is on its own row there's no need to use colour to draw attention to it; please remove the inline styles and in the new row.

nit: use "Yes" and "No" instead of "YES" and "NO".

@@ +40,5 @@
> +    'use strict';
> +    var securemail_groups = [];
> +    [% FOREACH group = groups %]
> +      [% IF group.secure_mail %]
> +    securemail_groups.push('[% group.id FILTER js %]');

this line need indentation

@@ +46,5 @@
> +    [% END %]
> +    $(document).ready(function() {
> +        for (var i = 0, l = securemail_groups.length; i < l; i++) {
> +            $("label[for='group_" + securemail_groups[i] + "']")
> +                .append(' <span style=\"color:blue;\">(secure mail)</span>');

remove the colouring here as well please

Comment 8

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   a2a7527..98503a6  master -> master