1190081 - We should keep the muted icon on the tab if the media element pauses its playback

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(no longer active)]

I think I mistakenly regressed this at some point when I was working on bug 486262...

Right now if you mute a tab and then it stops playback (for example on youtube if you pause the video) the muted icon is removed, which is misleading since the user would have no way of knowing that the tab is muted.  We should keep that icon on the tab.

Comment 1

[(no longer active)]

Attachment: Keep the tab muted icon visible even when the audio playback on the tab has been stopped

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8642052 [details] [diff] [review]
Keep the tab muted icon visible even when the audio playback on the tab has been stopped

Review of attachment 8642052 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this doesn't fix it for pinned tabs.

Comment 3

[(no longer active)]

Oh, you're right.  I actually never implemented that!

Comment 4

[(no longer active)]

Attachment: Keep the tab muted icon visible and functional even when the audio playback on the tab has been stopped

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e164271ed3fc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e164271ed3fc

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 42.0a2 (buildID: 20150826004006).