1190106 - tab-sound-icon indicate wrong state after the tab was moved to another browser by drag & drop

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

Steps to reproduce
1. Open 2 browser window
2. Open and play youtube html5 video on a new tab
    e.g.,  www.youtube.com/watch?v=BRG5VNNUq_E&hd=1&html5=1
3. Mute by click tab-sound-icon
4. Move the tab to another browser by drag & drop

Actual Results:
Sound keeps mute as expected, however tab-sound-icon indicates un-mute

Comment 1

[(no longer active)]

Attachment: Preserve the playing and muted icons when swapping browsers; r=jaws

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8642099 [details] [diff] [review]
Preserve the playing and muted icons when swapping browsers; r=jaws

Review of attachment 8642099 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_audioTabIcon.js
@@ +110,5 @@
> +  ok(oldTab.hasAttribute("muted"), "Expected the correct muted attribute on the old tab");
> +  is(oldTab.hasAttribute("soundplaying"), isPlaying, "Expected the correct soundplaying attribute on the old tab");
> +
> +  let newTab = gBrowser.getTabForBrowser(newBrowser);
> +  let AttrChangePromise = BrowserTestUtils.waitForEvent(newTab, "TabAttrModified", false, event => {

nit, s/AttrChangePromise/attrChangePromise/

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fdfa9d502f8

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for M-e10s(bc2) bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/d24ed1ad39df

[Child 2004] ###!!! ABORT: Content child abort due to IPC error: file /builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/ContentChild.cpp, line 1964
[Child 2004] ###!!! ABORT: Content child abort due to IPC error: file /builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/ContentChild.cpp, line 1964
108 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_audioTabIcon.js | Test timed out - expected PASS
110 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_audioTabIcon.js | Found a tab after previous test timed out: about:blank - expected PASS
111 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_audioTabIcon.js | Found a tab after previous test timed out: https://example.com/browser/browser/base/content/test/general/file_mediaPlayback.html - expected PASS
112 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_audioTabIcon.js | Found a tab after previous test timed out: data:text/html,test - expected PASS
PROCESS-CRASH | Main app process exited normally | application crashed [@ mozalloc_abort(char const*)]

Comment 5

[(no longer active)]

The bustage seems to be a reproducible IPC bug.  I'm going to add a workaround to the test which is basically waiting 1 second after the first browser swap, and we'll take that out when bug 1190903 gets fixed.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a9d48b58545

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a9d48b58545

Comment 8

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150813124640).