Closed Bug 1190148 Opened 4 years ago Closed 4 years ago

Fix warnings in toolkit/crashreporter/client and mark as FAIL_ON_WARNINGS

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

toolkit/crashreporter/client/crashreporter_gtk_common.cpp:416:5: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

toolkit/crashreporter/client/crashreporter_osx.mm:282:43: warning: semicolon before method body is ignored [-Wsemicolon-before-method-body]

Also remove unnecessary NULL checks before calling free().
Attachment #8642139 - Flags: review?(ted)
Attachment #8642139 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/53950d5bdf72
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.