1190149 - Fix -Wformat NULL sentinel warning in GStreamerReader-0.10.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: GStreamerReader_Wformat.patch

Change NULL sentinel to nullptr to fix this -Wformat warning:

dom/media/gstreamer/GStreamerReader-0.10.cpp:181:11: warning: missing sentinel in function call [-Wformat]

The C++ NULL is the literal 0. In a varargs context where the caller doesn't know the implicit type the callee function will be using to access its arguments, the literal 0 can be interpreted as an integer 0 (32-bits) instead of a NULL pointer (64-bits) on a 64-bit machine, leaving the high bits of the pointer uninitialized.

http://linuxonly.nl/docs/2/2_GCC_4_warnings_about_sentinels.html

Also add some blank lines around some #ifdefs to make them easier to read.

Comment 1

[Chris Peterson [:cpeterson]]

Thanks, Edwin!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9525bd428207

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9525bd428207