Closed Bug 1190185 Opened 4 years ago Closed 4 years ago

Switch default search engine to DuckDuckGo

Categories

(SeaMonkey :: Search, defect)

defect
Not set

Tracking

(seamonkey2.41 fixed)

RESOLVED FIXED
seamonkey2.41
Tracking Status
seamonkey2.41 --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Make the switch (obsolete) — Splinter Review
DuckDuckGo (https://duckduckgo.com) is a privacy-oriented search engine, we should potentially switch en-US locale to use it as the default search engine and the first choice in the drop down list.
Attachment #8642180 - Flags: review?(mnyromyr)
Attachment #8642180 - Flags: review?(bugzilla)
Attachment #8642180 - Flags: feedback?(rpmdisguise-otros)
Attachment #8642180 - Flags: feedback?(philip.chee)
Attachment #8642180 - Flags: feedback?(akalla)
We have another reference to Google as Search Provider:

http://hg.mozilla.org/comm-central/file/c2af6863c9a9/suite/locales/en-US/profile/bookmarks.extra

We don't need to touch it to make the default search engine switch, but perhaps we would like to change this file, too?

With regards to the proposed patch, it looks fine to me.
Attachment #8642180 - Flags: feedback?(rpmdisguise-otros) → feedback+
Added line for DuckDuckGo to bookmarks.extra
Attachment #8642180 - Attachment is obsolete: true
Attachment #8642180 - Flags: review?(mnyromyr)
Attachment #8642180 - Flags: review?(bugzilla)
Attachment #8642180 - Flags: feedback?(philip.chee)
Attachment #8642180 - Flags: feedback?(akalla)
Attachment #8642363 - Flags: review?(mnyromyr)
Attachment #8642363 - Flags: review?(bugzilla)
Attachment #8642363 - Flags: feedback?(philip.chee)
Attachment #8642363 - Flags: feedback?(akalla)
Comment on attachment 8642363 [details] [diff] [review]
Make the switch v1.1 [Checked in: Comment 7]

1. This file appears to have been updated already
http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/searchplugins/list.txt

2. We should announce this in advance in all the user/support forums plus blog about it.
Attachment #8642363 - Flags: feedback?(philip.chee) → feedback+
(In reply to Philip Chee from comment #3)
> Comment on attachment 8642363 [details] [diff] [review]
> Make the switch v1.1
> 
> 1. This file appears to have been updated already
> http://mxr.mozilla.org/comm-central/source/suite/locales/en-US/searchplugins/
> list.txt


Just keep in mind that list.txt is not intended to carry on any information about the preference order, just a (usually alphabetically ordered) list of searchplugins in the directory.
Comment on attachment 8642363 [details] [diff] [review]
Make the switch v1.1 [Checked in: Comment 7]

I briefly considered proposing to change the docs (nav_help.xhtml) as well, but it already claims its usage of Google is just an example.
r=me either way.
Attachment #8642363 - Flags: review?(mnyromyr) → review+
Comment on attachment 8642363 [details] [diff] [review]
Make the switch v1.1 [Checked in: Comment 7]

Review of attachment 8642363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good
Attachment #8642363 - Flags: feedback?(akalla) → feedback+
Comment on attachment 8642363 [details] [diff] [review]
Make the switch v1.1 [Checked in: Comment 7]

http://hg.mozilla.org/comm-central/rev/26d189d4d8e1
Attachment #8642363 - Attachment description: Make the switch v1.1 → Make the switch v1.1 [Checked in: Comment 7]
Attachment #8642363 - Flags: review?(bugzilla)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.41
You need to log in before you can comment on or make changes to this bug.