1190239 - Add bash completion for `mach build` targets

Status: NEW

(Firefox Build System :: General, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

This subcommand seems to mostly accept a directory, which natively works fine. However it also accepts several pseudo target, in which "binaries" is the one I use the most frequently.

It would be great if some of the frequently-used pseudo target could also be auto-completed in bash.

Comment 1

[Gregory Szorc [:gps]]

The bash completion is driven by `mach mach-commands`. What you are asking for is 2 things:

1) `mach mach-commands` support for listing sub-commands and/or additional valid positional arguments for commands
2) `mach build` to make such information available. Right now, there is no single list of available build targets. You have GNU make to thank for that. Modern build systems like Pants expose a list of known targets and make autocomplete trivial to implement. But, we can always roll our own manual list to facilitate autocomplete.

Leaving this in Core :: mach for now since we need a feature in mach itself to unblock this.

Comment 2

[Andrew Halberstadt [:ahal]]

Step 1 was finished by bug 1518586. I'm unclear if 2) is still an issue or not, so I'll leave this open. However, the mach pieces needed for this are done so moving out of this component.