1190243 - Update gaia battery api to use new W3C draft

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Please see bug 1050749.

Use navigator.getBattery() instead of navigator.battery.

Comment 1

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Would you help to make the change?

Thank you.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Yes, taking!

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

The patch is mostly complete. It passes almost all Gu tests except of two. I need a test B2G build to test it further.

Is there an option we'll get a transition period when both, navigator.battery and navigator.getBattery will work?

This would enable us to transition without having to land risky patches and trying to narrow down the window when all our builds fail.

Comment 5

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

According to bug 1050749 comment 22 and bug 1050749 comment 23, I guess we just have to land these patches in the same time, or we'll need to decide when to remove the transition.

Comment 6

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Bug 1050749 has been landed, I think now it will be easier to make the transition.

Comment 7

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

Can we land this patch? or this is no longer needed for gaia?

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8642793 [details] [review]
pull request

This patch migrates all ./apps to use the new API. I tested all unit tests that I touch and they all pass green locally.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1190243-update-battery-api-tv > mozilla-b2g:master

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8731807 [details] [review]
[gaia] zbraniecki:1190243-update-battery-api-tv > mozilla-b2g:master

And the TV counterpart, much smaller :)

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit for Phone: https://github.com/mozilla-b2g/gaia/commit/b82102840c2acf0a47048f1f8a58ea0764bd2b21

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8731807 [details] [review]
[gaia] zbraniecki:1190243-update-battery-api-tv > mozilla-b2g:master

Looks great to me for that small promisify patch :)

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/5514c1b4cc674930bf1aa98ee98643dcf418bd82

:wcp - I believe you can remove navigator.battery now! :)

Comment 14

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

I created bug 1259335 to track the API removal.