1190276 - [Messages] In a "new" activity we don't keep the body if the phone number has a conversation already

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. Use a 'new' activity with both body and phone number; the phone number must belong to an existing conversation.

Expected:
* We should be redirected to the correct conversation.
* The composer should be prefilled.

Actual:
* We're redirected to the correct conversation but the composer stays empty.

(attachment to reproduce to come)

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: test-activity-new.html

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] julienw:1190276-body-and-number-activity > mozilla-b2g:master

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8642345 [details] [review]
[gaia] julienw:1190276-body-and-number-activity > mozilla-b2g:master

Hey Oleg,

here is a small patch to fix this simple issue I found while working on bug 1162030.

As I explained last week, I chose to move to the Composer instead of the Conversation in case we had both a recipient and a body, even if the recipient has an existing conversation. The reason is that if the conversation has a draft, I couldn't think of a right behavior in this case.

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8642345 [details] [review]
[gaia] julienw:1190276-body-and-number-activity > mozilla-b2g:master

Looks good! Just few minor nits and question about unit test at github.

Thanks!

Comment 5

[Julien Wajsberg [:julienw]]

fixed nits and landed
master: 9ac577619f17877c3831c960d7ec0b5524497b30