1190316 - Fullscreen transition applied to all screens

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[John Drinkwater (:beta)]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150802030218

Steps to reproduce:

1, Open Firefox Nightly on my second screen
2, Watch a youtube video (ie https://www.youtube.com/watch?v=UCieWwIX1Ig ) and press fullscreen button
3, Expect video to maximise on my second monitor


Actual results:

Both screens go through a lengthy “blink” transition


Expected results:

Expected just the second screen to play this transition.

Comment 1

[Johannes Pfrang [:johnp]]

Confirmed on Fedora 22 KDE with latest nightly. It doesn't matter on which monitor the video goes fullscreen, the other monitor always plays the same animation.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Are you both using KDE?

Comment 3

[John Drinkwater (:beta)]

For me, gnome-flashback, which is Gnome 3 with Gnome 2 behaviours.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Sorry that I didn't test it with multiple monitors.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/009a2d6aa52c3fa1bd78462654234b27ed0a6636
changeset:  009a2d6aa52c3fa1bd78462654234b27ed0a6636
user:       Xidorn Quan <[e-mail]>
date:       Thu Aug 13 08:53:53 2015 +1000
description:
Bug 1190316 - Apply fullscreen transition on only the target monitor. r=roc

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8646762 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1160014 which introduced the transition
[User impact if declined]: the transition will cover all monitors on Linux
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: no risk, the fix is simple and straightforward
[String/UUID change made/needed]: n/a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/009a2d6aa52c

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8646762 [details] [diff] [review]
patch

Taking it as we will have more attention on the GNU/Linux release with the gtk3 release.
"[Risks and why]: no risk, the fix is simple and straightforward"
I don't agree with this evaluation of the risk. Every patch brings some risks and this one is no different...

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/15d22701fdae