1190330 - Test coverage for webRequest extension API

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Gabor Krizsanits (INACTIVE)]

https://wiki.mozilla.org/Browser_Extensions#List_of_supported_APIs

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This test is largely copied from toolkit/modules/tests/browser/browser_WebRequest.js.

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8651401 [details] [diff] [review]
patch

Review of attachment 8651401 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/test/extensions/webrequest/background.js
@@ +31,5 @@
> +  if (details.url.startsWith(BASE)) {
> +    requested.push(details.url);
> +
> +    if (savedTabId == -1) {
> +      browser.test.assertTrue(details.tabId !== undefined, "tab ID defined");

I know this is the original API, but I'm a bit tempted to just define is/ok/etc. too on top of them since browser.test.assertTrue looks just painfully bloated :( What do you think?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Accidentally landed this with the wrong bug number:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91e5acc46643
I'll close this bug out when the other one is closed.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Fabrice, I had to land this with b2g support disabled because of a crash when loading a process script:
https://treeherder.mozilla.org/logviewer.html#?job_id=10650232&repo=try
It seems like we're trying to load the process script into a Nuwa process.

Is there any chance you can look into this? It would be nice to have webRequest support on b2g.

Comment 5

[[:fabrice] Fabrice Desré]

(In reply to Bill McCloskey (:billm) from comment #4)
> Fabrice, I had to land this with b2g support disabled because of a crash
> when loading a process script:
> https://treeherder.mozilla.org/logviewer.html#?job_id=10650232&repo=try
> It seems like we're trying to load the process script into a Nuwa process.
> 
> Is there any chance you can look into this? It would be nice to have
> webRequest support on b2g.

I'm working on that in bug 1198970

Comment 6

[[:fabrice] Fabrice Desré]

fwiw, I pushed to try with a b2g implementation of webRequest, and after a Nuwa preloading patch landed (bug 1166207). It seems that we don't crash anymore, but still don't pass.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=990a127750a8