Closed Bug 1190331 Opened 6 years ago Closed 5 years ago
Test coverage for windows extension API
48.3 - Apr 25
This is still missing coverage for: * The |onCreated|, |onRemoved|, and |onFocusChanged| events. * The |get|, |getLastFocused|, |create|, and |remove| API methods. * The |update| method without the |focused| property. https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
The above mentioned list of missing coverage does not seem to be entirely accurate, according to https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html. I am going to open some blocking bugs for the specific coverage that is needed.
Iteration: 48.2 - Apr 4 → 48.3 - Apr 18
Once both dependencies for this are fixed this can be marked as fixed as well.
All of the existing dependencies are marked as resolved, which seems to suggest this can also be marked as resolved, although looking at the coverage report at  there is still coverage missing for |onFocusChanged| and |getLastFocused|. Kris, are those reports still updated on a weekly basis?  https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Flags: blocking-webextensions+ → needinfo?(kmaglione+bmo)
No, the coverage tests are currently broken due to some changes in the content process shutdown sequence. I'm hopping to have it fixed this week.
It looks like both |onFocusChanged|  and |getLastFocused|  are now covered. I will leave this open until we get the coverage reports running again, at which point I will verify that ext-windows.js is fully covered. Kris, if you could add a comment to this bug once coverage reports are restored that would be great, thanks.  https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#20  https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#30
According to , which was run on August 24, ext-windows.js has 100% coverage. Yay!  https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.