1190331 - Test coverage for windows extension API

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Gabor Krizsanits (INACTIVE)]

https://wiki.mozilla.org/Browser_Extensions#List_of_supported_APIs

Comment 1

[Kris Maglione [:kmag]]

This is still missing coverage for:

* The |onCreated|, |onRemoved|, and |onFocusChanged| events.
* The |get|, |getLastFocused|, |create|, and |remove| API methods.
* The |update| method without the |focused| property.


https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html

Comment 2

[Bob Silverberg [:bsilverberg]]

The above mentioned list of missing coverage does not seem to be entirely accurate, according to https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html. I am going to open some blocking bugs for the specific coverage that is needed.

Comment 3

[Bob Silverberg [:bsilverberg]]

Once both dependencies for this are fixed this can be marked as fixed as well.

Comment 4

[Bob Silverberg [:bsilverberg]]

All of the existing dependencies are marked as resolved, which seems to suggest this can also be marked as resolved, although looking at the coverage report at [1] there is still coverage missing for |onFocusChanged| and |getLastFocused|. Kris, are those reports still updated on a weekly basis?

[1] https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html

Comment 5

[Kris Maglione [:kmag]]

No, the coverage tests are currently broken due to some changes in the content process shutdown sequence. I'm hopping to have it fixed this week.

Comment 6

[Bob Silverberg [:bsilverberg]]

It looks like both |onFocusChanged| [1] and |getLastFocused| [2] are now covered. I will leave this open until we get the coverage reports running again, at which point I will verify that ext-windows.js is fully covered. 

Kris, if you could add a comment to this bug once coverage reports are restored that would be great, thanks.

[1] https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#20
[2] https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#30

Comment 7

[Bob Silverberg [:bsilverberg]]

According to [1], which was run on August 24, ext-windows.js has 100% coverage. Yay!

[1] https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html