Closed Bug 1190331 Opened 6 years ago Closed 5 years ago

Test coverage for windows extension API

Categories

(WebExtensions :: Untriaged, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Iteration:
48.3 - Apr 25

People

(Reporter: gkrizsanits, Assigned: bsilverberg)

References

Details

(Whiteboard: [testing] triaged)

Blocks: 1185459
This is still missing coverage for:

* The |onCreated|, |onRemoved|, and |onFocusChanged| events.
* The |get|, |getLastFocused|, |create|, and |remove| API methods.
* The |update| method without the |focused| property.


https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
Flags: blocking-webextensions-
Flags: blocking-webextensions- → blocking-webextensions+
Assignee: nobody → evilpies
Assignee: evilpies → nobody
Assignee: nobody → bob.silverberg
Whiteboard: [testing] triaged
Iteration: --- → 48.2 - Apr 4
The above mentioned list of missing coverage does not seem to be entirely accurate, according to https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html. I am going to open some blocking bugs for the specific coverage that is needed.
Depends on: 1261185
Depends on: 1261949
Iteration: 48.2 - Apr 4 → 48.3 - Apr 18
Once both dependencies for this are fixed this can be marked as fixed as well.
Depends on: 1262976
All of the existing dependencies are marked as resolved, which seems to suggest this can also be marked as resolved, although looking at the coverage report at [1] there is still coverage missing for |onFocusChanged| and |getLastFocused|. Kris, are those reports still updated on a weekly basis?

[1] https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Flags: blocking-webextensions+ → needinfo?(kmaglione+bmo)
No, the coverage tests are currently broken due to some changes in the content process shutdown sequence. I'm hopping to have it fixed this week.
Flags: needinfo?(kmaglione+bmo)
It looks like both |onFocusChanged| [1] and |getLastFocused| [2] are now covered. I will leave this open until we get the coverage reports running again, at which point I will verify that ext-windows.js is fully covered. 

Kris, if you could add a comment to this bug once coverage reports are restored that would be great, thanks.

[1] https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#20
[2] https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_windows_events.js#30
According to [1], which was run on August 24, ext-windows.js has 100% coverage. Yay!

[1] https://people.mozilla.org/~kmaglione/webextension-test-coverage/browser/components/extensions/ext-windows.js.html
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.