Closed Bug 1190337 Opened 5 years ago Closed 5 years ago

[B2G] Log GPS status and SVs status if the 'gDebug_isLoggingEnabled' is true.

Categories

(Core :: DOM: Geolocation, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jaliu, Assigned: jaliu)

References

Details

Attachments

(1 file, 1 obsolete file)

GPS status represents the status of GPS engine.
It's useful for developer to know the state of GPS hardware.

On the other hand, GpsSvStatus can tell developer how many SVs are currently, visible and how many SVs have valid almanac and ephemeris data.

There information is helpful for debugging, therefore, I believe it's reasonable to log GPS status and SVs status if the 'gDebug_isLoggingEnabled' is true.
Assignee: nobody → jaliu
Status: NEW → ASSIGNED
Hi Garvan,
The information from the log would be useful for understanding the progress of GPS positioning, including the number of visible SVs and the status of ephemeris and almanac.

Would you mind to review the patch ?
Thank you.
Attachment #8642365 - Flags: review?(gkeeley)
Comment on attachment 8642365 [details] [diff] [review]
Log GPS status and SVs status (v1)

Review of attachment 8642365 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, this will be very helpful. I am fully supportive of lots of logging (controlled by this flag of course), we need all the info we can get from field to figure out GPS bugs.
Attachment #8642365 - Flags: review?(gkeeley) → review+
- Add reviewer's name to commit message
- Change the patch from git format to hg format.

Thank Garvan for reviewing the patch.
Attachment #8642365 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/6466924a3974
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Just a needinfo because I know this is something that is gonna make QA's life easier. We know get lines line:
> 08-07 11:00:29.958   315  1526 I GeckoConsole: geo: GPS got a fix (47.xx, 0.yy). accuracy: 11.000000
Flags: needinfo?(nhirata.bugzilla)
Flags: needinfo?(jlorenzo)
Flags: needinfo?(jlorenzo)
You need to log in before you can comment on or make changes to this bug.