1190337 - [B2G] Log GPS status and SVs status if the 'gDebug_isLoggingEnabled' is true.

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Jamin Liu [:jaliu][:Jamin]]

GPS status represents the status of GPS engine.
It's useful for developer to know the state of GPS hardware.

On the other hand, GpsSvStatus can tell developer how many SVs are currently, visible and how many SVs have valid almanac and ephemeris data.

There information is helpful for debugging, therefore, I believe it's reasonable to log GPS status and SVs status if the 'gDebug_isLoggingEnabled' is true.

Comment 1

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Log GPS status and SVs status (v1)

Hi Garvan,
The information from the log would be useful for understanding the progress of GPS positioning, including the number of visible SVs and the status of ephemeris and almanac.

Would you mind to review the patch ?
Thank you.

Comment 2

[:garvan]

Comment on attachment 8642365 [details] [diff] [review]
Log GPS status and SVs status (v1)

Review of attachment 8642365 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, this will be very helpful. I am fully supportive of lots of logging (controlled by this flag of course), we need all the info we can get from field to figure out GPS bugs.

Comment 3

[Jamin Liu [:jaliu][:Jamin]]

Attachment: Log GPS status and SVs status (v1), r=garvank

- Add reviewer's name to commit message
- Change the patch from git format to hg format.

Thank Garvan for reviewing the patch.

Comment 4

[Jamin Liu [:jaliu][:Jamin]]

It looks fine on try server.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0180ba139515

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6466924a3974

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6466924a3974

Comment 7

[:gerard-majax]

Just a needinfo because I know this is something that is gonna make QA's life easier. We know get lines line:
> 08-07 11:00:29.958   315  1526 I GeckoConsole: geo: GPS got a fix (47.xx, 0.yy). accuracy: 11.000000

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks.  Added to here : https://wiki.mozilla.org/B2G/QA/Geolocation#Testing