1190341 - audio/aacp shoutcast is not supported

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Roger Hågensen]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150630154324

Steps to reproduce:

Go to http.//player.gridstream.org/
Press PLAY


Actual results:

No music.


Expected results:

To hear music. Just like it does in Chrome or Edge.

Chrome and Edge either treats audio/aacp as a alias for audio/mpeg or audio/mp4.

The Webplayer does a check for audio/mp4; codecs="mp4a.40.2" as both Chrome and Edge state they support that when using canPlayType(), audio/aacp returns false even if it is supported/possible so using canPlayType() to check for audio/aacp support is not reliable.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Does it work in nightly?

Comment 2

[Matthias Versen [:Matti]]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #1)
> Does it work in nightly?

it doesn't work with the latest nightly on windows7.
I didn't confirm this bug because I'm not sure if we want to support playing audio/aacp

Comment 3

[Ralph Giles (:rillian)]

We don't have resources for this, unless it's just adts, in which case, see bug 1169212.

Comment 4

[Roger Hågensen]

(In reply to Ralph Giles (:rillian) from comment #3)
> We don't have resources for this, unless it's just adts, in which case, see
> bug 1169212.

A shoutcast audio/aacp stream is AAC ADTS.


Could this bug be marked as being related to the other one?
If bug 1169212 is taken care of AND audio/aacp is recognized then that will take of 1190341 (this bug) as well.

Comment 5

[Roger Hågensen]

This bug is related to https://bugzilla.mozilla.org/show_bug.cgi?id=809186

Comment 6

[Ralph Giles (:rillian)]

(In reply to Roger Hågensen from comment #4)

> A shoutcast audio/aacp stream is AAC ADTS.

Ok, thanks. We should be able to fix all these together then. I may not get to the ADTSDemuxer for a while though.

Comment 7

[Ralph Giles (:rillian)]

We've changed our minds about ADTS support. Your best bet here is to use the MediaSource Extensions API and remux AAC ADTS into m4a in javascript.

Comment 8

[Roger Hågensen]

(In reply to Ralph Giles (:rillian) from comment #7)
> We've changed our minds about ADTS support. Your best bet here is to use the
> MediaSource Extensions API and remux AAC ADTS into m4a in javascript.

OK!

Just be aware that while I could program that it would not work with the example link in the original post.
The SHOUTcast server is hosted at a streamhost, and they do not provide/support CORS nor can the web player files be stored on the stream server so same origin is not possible.
Without same origin or CORS it's not possible to manipulate the audio but it's not possible to even analyze the audio stream (I tried to make a VUMeter for the player but ran into issues due to the lack of CORS on the streamserver).

SHOUTcast v2 supports CORS (I think), but SHOUTcast v1 does not. There is still a large number of v1 servers out there. I can't recall what Icecast does in regards to CORS support.


So in conclusion while I can code remuxing it won't work (there woulds be a CORS warning if it's tried).
As to the streamhost and CORS that is something I'll have to talk with the station owner about and see if he can work something out with the hosting company.
At least listeners will be able to use Chrome or Edge to listen to the stream currently, we'll just advise them to not use Firefox since it doesn't support SHOUTcast AAC(+) streams. Ironically the station owner uses and likes Firefox and was the only reason I created this bug entry.

If the station owner and the hosting company can get CORS support going then I'll probably modify the player so it works on Firefox if it's not too much work and the processing overhead it creates is not too high vs the native HTML5 player/decoder.

Also once Opus gets some traction I'll advise the station owner to move to Icecast with a Opus stream instead, but right now AAC(+) is the dominant codec (MP3 and AAC was tested at the same bitrate and AAC+ was found to much sound better than both, so going to MP3 is not an option either).

I understand you guys need to prioritize things, it's just a shame that SHOUTcast with a AAC(+) stream won't work with Firefox as I rather like Firefox myself as well.

Feel free to close/resolve this bug as this is probably by last comment/closing argument, I have nothing further to add really.

(For anyone else curious as to the reason of Firefox devs not supporting SHOUTCast AAC see https://bugzilla.mozilla.org/show_bug.cgi?id=809186#c39 a statement I agree with but is just ironically unfortunate in this case.)

Thanks for taking the time to evaluate this bug/ticket though, I appreciate you taking the time.

Comment 9

[u480271]

Fixed by Bug 1169212