Last Comment Bug 1190476 - set Comment field in GPG email to the URL of the bug
: set Comment field in GPG email to the URL of the bug
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: Extensions: SecureMail (show other bugs)
: Production
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-08-03 10:58 PDT by Richard Soderberg [:atoll]
Modified: 2015-08-20 06:36 PDT (History)
3 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
1190476_1.patch (4.83 KB, patch)
2015-08-19 00:04 PDT, Byron Jones ‹:glob›
dkl: review+
Details | Diff | Splinter Review

Description User image Richard Soderberg [:atoll] 2015-08-03 10:58:29 PDT
When sending bugmail, we plaintext reference the bug # in the email plaintext headers. It would be helpful to have a direct link to the bug in the plaintext email as well (when viewing GPG emails on non-GPG clients).

Could you please activate the 'comment' attribute in the Crypt::OpenGPG code?

https://github.com/btrott/Crypt-OpenPGP/blob/77352f28bfa9f9ad9f31f8ac145b0be39c5addba/lib/Crypt/OpenPGP/Armour.pm#L142

indicates that you just need to add a 'Comment => $bmo_url' parameter to the Headers hash.

I request that the URL is the *only thing* in the Comment, since no further information is required and that provides the best usability (obvious clickable url on line 4 of the email).
Comment 1 User image Gervase Markham [:gerv] 2015-08-03 11:00:22 PDT
Weird. I thought of this idea just the other day, then forgot it again :-)

Gerv
Comment 2 User image Byron Jones ‹:glob› 2015-08-19 00:04:13 PDT
Created attachment 8649705 [details] [diff] [review]
1190476_1.patch

i performed some testing with atoll and this appears to do the trick.
Comment 3 User image Richard Soderberg [:atoll] 2015-08-19 00:07:25 PDT
Before:

-----BEGIN PGP MESSAGE-----
Version: Crypt::OpenPGP 1.04

hQIOA7Z/9NBBpcqLEAf/bMV+r9xTcPKkbUmoxzjFs8NlVQ/v4vyeAVF9AhTr70JP


After:

-----BEGIN PGP MESSAGE-----
Comment: http://bz/1190476/show_bug.cgi?id=888

hQMMA7Z/9NBBpcqLEAgAilS8GOEtWVvdLlFTxU1jd+8rH3zxiJUbIZbiTgTMXeBM


The message decrypts cleanly and to the same content as before.
Comment 4 User image David Lawrence [:dkl] 2015-08-19 13:46:52 PDT
Comment on attachment 8649705 [details] [diff] [review]
1190476_1.patch

Review of attachment 8649705 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Comment 5 User image Byron Jones ‹:glob› 2015-08-20 06:36:14 PDT
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   df1f6c9..667ecc3  master -> master

Note You need to log in before you can comment on or make changes to this bug.