1190498 - [Gallery] Sharing photo from Gallery to Facebook does not set photo in post box.

Status: RESOLVED WONTFIX

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20150803_1040.txt

Description:
If a photo is being shared to Facebook from Gallery or Preview then Facebook will launch without the photo being set within the post box. This is inconsistent when compared to Windows or I-Phone as the photo will already be set within the posting box with the options to write text. 


Repro Steps:

Prereq: Previously logged into Facebook.

1) Update a Flame to 
2) Select a Photo within Gallery
3) Select Share > Facebook

Actual:
User will have to select the photo button and select the photo they want to share a 2nd time.

Expected:
It is expected that the photo previously selected will appear ready to post when sharing to Facebook.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (319mb)
Build ID: 20150803030210
Gaia: 2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gecko: 32712cd01159
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0


User Impact: User will manually have to select the photo they want to share on Facebook through the Facebook website. 


Repro frequency: 100%
See attached: Logcat & Video

Comment 1

[John Thomas [:Johnt]]

Step 1 should read as "Update a Flame to 20150803030210"

Comment 2

[John Thomas [:Johnt]]

This issue does NOT occur on Aries 2.5, Flame 2.2, 2.1 or 2.0

Environmental Variables:
Device: Aries 2.5 Kk
Build ID: 20150727151800
Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667
Gecko: 21ca97268bae
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Environmental Variables:
Device: Flame 2.2 Kk Fullflash (319mb)
BuildID: 20150803032504
Gaia: f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gecko: 429b9d2d4566
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0


Environmental Variables:
Device: Flame 2.1 Kk Fullflash (319mb)
Build ID: 20150724001207
Gaia: 9dba58d18006e921546cec62c76074ce81e16518
Gecko: 41e10c6740be
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0 Kk Fullflash (319mb)
Build ID: 20150723000207
Gaia: b16ba05481e577bc644ed8966f587a70fe2148e6
Gecko: 2e6f1d4deff9
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 32.0 (2.0)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression.

Requesting a window.

Comment 4

[Michael:mtreese]

Regression, please fix.

Comment 5

[John Thomas [:Johnt]]

I sincerely apologize. I left a typo regarding Comment 2. This issue DOES occur on Aries 2.5, Flame 2.2, 2.1 or 2.0.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

Not a regression.

Comment 7

[Punam Dahiya [:pdahiya]]

Investigated and share activity is successfully invoked from gallery app and is sending shared blob as data to facebook app.

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/gallery.js#L714

The issue seems to be at the receiving end for handling shared data in facebook app. Setting NI flag for David to help re-direct bug to appropriate component. Thanks!

Comment 8

[Hubert Figuiere [:hub]]

Isn't that related to bug 1178290 where the picture is named "blob" (when uploading to Flickr)?

Comment 9

[Punam Dahiya [:pdahiya]]

(In reply to Hubert Figuiere [:hub] from comment #8)
> Isn't that related to bug 1178290 where the picture is named "blob" (when
> uploading to Flickr)?

It shouldn't be as bug 1178290 is about downsized and unnamed blob, this issue appears to be displaying the returned shared blob inside facebook app.

Comment 10

[Punam Dahiya [:pdahiya]]

Tested and the shared image from camera app is not getting set on facebook app.

Comment 12

[David Flanagan [:djf]]

I can reproduce this on a foxfooding device, both with the pre-installed Facebook app, and with the Facebook (probably the same thing) from Marketplace.

It is not a regression.  It is not specific to Gallery, because Camera can't share images with Facebook either.  Gallery and Camera can share images with other apps like the SMS app, however.  So I'm pretty sure that this is a bug on Facebook's end.

I think this is a job for partner engineering. We need to ask Facebook to fix m.facebook.com to correctly handle share activities for FirefoxOS.  And if they can't do that, then they should modify https://m.facebook.com/openwebapp/manifest.webapp so that it does not incorrectly state that the app can handle the share activity. And while we're working with Facebook, it might be worth pointing out that the Pick activity from the facebook app does not usually seem to display previews of the images that the user has attached to their post before posting. That seems like a bug, too.

Harald: could you or one of your teammates work with Facebook on this?

Comment 13

[David Flanagan [:djf]]

Changing the component to Gaia:Foxfooding, since this does seem like a serious foxfooding issue.

And unassigning myself, since it is not something I can fix.

Doug: if we can't get Facebook to fix this on their end, can we work around it for foxfooders by having a local copy of Facebook's manifest that deletes the share activity instead of linking to https://m.facebook.com/openwebapp/manifest.webapp in distros/spark/remote.list?

Comment 14

[Michael Ellis]

Thank you for investigating this bug.  We will contact our partners @ FB and try for a resolution.

Comment 15

[Hubert Figuiere [:hub]]

David, Foxfooding isn't the component for that. It is the component for the app we wanted to ship be didn't. (we should remove that component /me think) 

Doesn't activity require installed apps at least (for permissions)? Isn't the Facebook app just hosted?

Comment 16

[Hubert Figuiere [:hub]]

See
https://developer.mozilla.org/en-US/docs/Web/API/MozActivity

Comment 17

[:Harald Kirschner :digitarald]

Correct me if I am wrong but this should be a Tech Evangelism bug. As far as I can understand this is a regression on the FB side. Sharing web activity worked before and correctly populated the composer image attachment. It sounds like this is completely broken by now, which isn't surprising as this probably didn't have any automated tests on the FB side (their testing cycle is mostly dogfooding based).

Comment 18

[David Flanagan [:djf]]

Thanks, Harald.  Changing this to tech evangelism.

Resetting the needinfo for Doug, though: since we're pre-installing the facebook app on Spark builds, do you want to use a local manifest so you can workaround this by deleting the busted share activity?

Comment 19

[Doug Sherk (:drs) (inactive)]

When bug 1196992 lands, we'll also be preloading Facebook into the base Gaia build. I'm surfacing this to the product team.

In my opinion, we should reach out to Facebook to have them fix this, and avoid building our own custom workarounds which will be difficult to back out of once the issues are fixed.

Comment 20

[Mahendra Potharaju [:mahe]]

NI'ed Product team as Wilfred is on vacation. 

Thanks

Comment 22

[Michael Ellis]

@DRS - This bug had been communicated to the partner.  The issue is that we are having a less-than-awesome time getting priority/attention on our bugs.  Although a work-around on our side may not be ideal, it may be the fastest route to a resolution.

Comment 23

[Sylvestre Ledru [:Sylvestre]]

B2G: we won't work on that.