Closed
Bug 1190615
Opened 10 years ago
Closed 10 years ago
nr_ice_component_initialize_udp disregards STUN server transport
Categories
(Core :: WebRTC: Networking, defect, P1)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
| backlog | webrtc/webaudio+ |
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_component.c#240
Assumes all STUN servers are UDP, but since we added ICE TCP STUN servers actually have a transport:
https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_ctx.h#65
|
Assignee | |
Comment 1•10 years ago
|
||
Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc
Attachment #8642692 -
Flags: review?(docfaraday)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8642692 [details]
MozReview Request: Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc
https://reviewboard.mozilla.org/r/14767/#review13369
Ship It!
::: media/mtransport/third_party/nICEr/src/ice/ice_component.c:240
(Diff revision 1)
> + /* Skip non-UDP */
> + if(ctx->stun_servers[j].transport!=IPPROTO_UDP)
> + continue;
> +
> if(r=nr_ice_candidate_create(ctx,component,
LGTM
Attachment #8642692 -
Flags: review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8642692 [details]
MozReview Request: Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc
https://reviewboard.mozilla.org/r/14767/#review13371
Ship It!
Attachment #8642692 -
Flags: review?(docfaraday) → review+
|
||
Updated•10 years ago
|
backlog: --- → webRTC+
Rank: 18
Priority: -- → P1
Keywords: checkin-needed
|
||
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•