nr_ice_component_initialize_udp disregards STUN server transport

RESOLVED FIXED in Firefox 42

Status

()

defect
P1
normal
Rank:
18
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

Trunk
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc
Attachment #8642692 - Flags: review?(docfaraday)
Comment on attachment 8642692 [details]
MozReview Request: Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc

https://reviewboard.mozilla.org/r/14767/#review13369

Ship It!

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c:240
(Diff revision 1)
> +        /* Skip non-UDP */
> +        if(ctx->stun_servers[j].transport!=IPPROTO_UDP)
> +          continue;
> +
>          if(r=nr_ice_candidate_create(ctx,component,

LGTM
Attachment #8642692 - Flags: review+
Comment on attachment 8642692 [details]
MozReview Request: Bug 1190615: skip non-UDP STUN servers for UDP sockets. r?bwc

https://reviewboard.mozilla.org/r/14767/#review13371

Ship It!
Attachment #8642692 - Flags: review?(docfaraday) → review+
backlog: --- → webRTC+
Rank: 18
Priority: -- → P1
Try run looks green.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/48f9d0c0f352
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.