Closed Bug 1190676 Opened 5 years ago Closed 5 years ago

"Assertion failure: cycleStackMarker == ps->mCycleMarker"

Categories

(Core :: Web Audio, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: jruderman, Assigned: padenot)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, testcase)

Attachments

(13 files, 3 obsolete files)

254 bytes, text/html
Details
1.55 KB, patch
roc
: review+
Details | Diff | Splinter Review
5.96 KB, patch
roc
: review+
Details | Diff | Splinter Review
9.20 KB, patch
roc
: review+
Details | Diff | Splinter Review
1.15 KB, patch
pehrsons
: review+
Details | Diff | Splinter Review
4.00 KB, patch
jesup
: review+
Details | Diff | Splinter Review
5.12 KB, patch
jesup
: review+
Details | Diff | Splinter Review
2.33 KB, patch
JamesCheng
: review+
Details | Diff | Splinter Review
1.10 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
1.33 KB, patch
roc
: review+
Details | Diff | Splinter Review
1.63 KB, patch
karlt
: review+
Details | Diff | Splinter Review
1.90 KB, patch
anatal
: review+
eeejay
: superreview+
Details | Diff | Splinter Review
1.77 KB, patch
pehrsons
: review+
Details | Diff | Splinter Review
Attached file testcase
Assertion failure: cycleStackMarker == ps->mCycleMarker, at dom/media/MediaStreamGraph.cpp:756

> #01: mozilla::MediaStreamGraphImpl::OneIteration(long long, long long, long long, long long) [dom/media/MediaStreamGraph.cpp:1514]
> #02: mozilla::ThreadedDriver::RunThread() [dom/media/GraphDriver.cpp:302]
> #03: mozilla::MediaStreamGraphInitThreadRunnable::Run() [dom/media/GraphDriver.cpp:209]
> #04: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:867]
> #05: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:277]
> #06: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:326]
> #07: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:235]
> #08: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
> #09: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:362]
> #10: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:215]
Another instance of the same problem as last time.
Attachment #8643082 - Flags: review?(roc)
Assignee: nobody → padenot
Status: NEW → ASSIGNED
Hopefully this will prevent cross-graph connections and other madness.
Attachment #8643083 - Flags: review?(roc)
Hopefully this wil also prevent getting the wrong graph.
Attachment #8643085 - Flags: review?(roc)
Attachment #8643082 - Attachment is obsolete: true
Attachment #8643082 - Flags: review?(roc)
Hopefully this will prevent cross-graph connections.
Attachment #8643089 - Flags: review?(roc)
Attachment #8643083 - Attachment is obsolete: true
Attachment #8643083 - Flags: review?(roc)
Hopefully this wil also prevent getting the wrong graph.
Attachment #8643091 - Flags: review?(roc)
Attachment #8643085 - Attachment is obsolete: true
Attachment #8643085 - Flags: review?(roc)
I needed to stub a number of things to make this work, but I have mostly no
idea what I'm doing in the FakeMediaStream file.
Attachment #8643094 - Flags: review?(rjesup)
Attachment #8643095 - Flags: review?(rjesup)
James, it appears that you wrote this code initially, care to have a look at
this? I mostly need to know if there is a way to know whether the graph will
need audio when you call GetInstance.
Attachment #8643102 - Flags: review?(jacheng)
Attachment #8643106 - Flags: review?(sotaro.ikeda.g)
Attachment #8643113 - Flags: review?(anatal)
Attachment #8643094 - Flags: review?(rjesup) → review+
Attachment #8643095 - Flags: review?(rjesup) → review+
Attachment #8643092 - Flags: review?(pehrsons) → review+
Attachment #8643106 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8643111 [details] [diff] [review]
Part 10 - Fix consumers: AudioDestinationNode. r=

Please fold this into attachment 8643091 [details] [diff] [review], as I hope that won't compile without this change.
Attachment #8643111 - Flags: review?(karlt) → review+
Attachment #8643102 - Flags: review?(jacheng) → review+
Comment on attachment 8643113 [details] [diff] [review]
Part 11 - Fix consumers: Web Speech. r=

This looks good to me, but I'd like to ask eeejay to please double check since he's more familiar with Synthesis
Attachment #8643113 - Flags: superreview?(eitan)
Attachment #8643113 - Flags: review?(anatal)
Attachment #8643113 - Flags: review+
Comment on attachment 8643113 [details] [diff] [review]
Part 11 - Fix consumers: Web Speech. r=

Review of attachment 8643113 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'm not sure which AudioChannel we want to be on. But I assume we were on Normal before, so this is fine.
Attachment #8643113 - Flags: superreview?(eitan) → superreview+
This is orange on try, but I think 962719 will fix the errors.
Hrm, I forgot that I had added this after asking for all the reviews.
Attachment #8653521 - Flags: review?(pehrsons)
Comment on attachment 8653521 [details] [diff] [review]
Part 12 - Fix mozCaptureStream. r=

Review of attachment 8653521 [details] [diff] [review]:
-----------------------------------------------------------------

One of these in CaptureStreamInternal() should suffice.
Attachment #8653521 - Flags: review?(pehrsons) → review+
You need to log in before you can comment on or make changes to this bug.