1190676 - "Assertion failure: cycleStackMarker == ps->mCycleMarker"

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: cycleStackMarker == ps->mCycleMarker, at dom/media/MediaStreamGraph.cpp:756

> #01: mozilla::MediaStreamGraphImpl::OneIteration(long long, long long, long long, long long) [dom/media/MediaStreamGraph.cpp:1514]
> #02: mozilla::ThreadedDriver::RunThread() [dom/media/GraphDriver.cpp:302]
> #03: mozilla::MediaStreamGraphInitThreadRunnable::Run() [dom/media/GraphDriver.cpp:209]
> #04: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:867]
> #05: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/glue/nsThreadUtils.cpp:277]
> #06: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:326]
> #07: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:235]
> #08: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:520]
> #09: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:362]
> #10: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:215]

Comment 1

[Paul Adenot (:padenot)]

Attachment: Use the right MediaStreamGraph when setting a MediaStream as mozSrcStream on an HTMLMediaElement. r=

Another instance of the same problem as last time.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Force explicitely passing in a MediaStreamGraph when creating a DOMMediaStream. r=

Hopefully this will prevent cross-graph connections and other madness.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Make getting a MediaStreamGraph for a channel more explicit. r=

Hopefully this wil also prevent getting the wrong graph.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Part 1 - Use the right MediaStreamGraph when setting a MediaStream as mozSrcStream on an HTMLMediaElement. r=

Comment 5

[Paul Adenot (:padenot)]

Attachment: Part 2 - Force explicitely passing in a MediaStreamGraph when creating a DOMMediaStream. r=

Hopefully this will prevent cross-graph connections.

Comment 6

[Paul Adenot (:padenot)]

Attachment: Part 3 - Make getting a MediaStreamGraph for a channel more explicit. r=

Hopefully this wil also prevent getting the wrong graph.

Comment 7

[Paul Adenot (:padenot)]

Attachment: Part 4 - Fix consumers: CanvasCaptureMediaStream. r=

Comment 8

[Paul Adenot (:padenot)]

Attachment: Part 5 - Fix consumers: PeerConnection. r=

I needed to stub a number of things to make this work, but I have mostly no
idea what I'm doing in the FakeMediaStream file.

Comment 9

[Paul Adenot (:padenot)]

Attachment: Part 6 - Fix consumers: MediaManager. r=

Comment 10

[Paul Adenot (:padenot)]

Attachment: Part 7 - Fix consumers: InputPort and HWMediaStream. r=

James, it appears that you wrote this code initially, care to have a look at
this? I mostly need to know if there is a way to know whether the graph will
need audio when you call GetInstance.

Comment 11

[Paul Adenot (:padenot)]

Attachment: Part 8 - Fix consumers: CameraPreviewMediaStream. r=

Comment 12

[Paul Adenot (:padenot)]

Attachment: Part 9 - Fix consumers: AudioCapture. r=

Comment 13

[Paul Adenot (:padenot)]

Attachment: Part 10 - Fix consumers: AudioDestinationNode. r=

Comment 14

[Paul Adenot (:padenot)]

Attachment: Part 11 - Fix consumers: Web Speech. r=

Comment 15

[Karl Tomlinson (:karlt)]

Comment on attachment 8643111 [details] [diff] [review]
Part 10 - Fix consumers: AudioDestinationNode. r=

Please fold this into attachment 8643091 [details] [diff] [review], as I hope that won't compile without this change.

Comment 16

[André Natal]

Comment on attachment 8643113 [details] [diff] [review]
Part 11 - Fix consumers: Web Speech. r=

This looks good to me, but I'd like to ask eeejay to please double check since he's more familiar with Synthesis

Comment 17

[Eitan Isaacson [:eeejay]]

Comment on attachment 8643113 [details] [diff] [review]
Part 11 - Fix consumers: Web Speech. r=

Review of attachment 8643113 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'm not sure which AudioChannel we want to be on. But I assume we were on Normal before, so this is fine.

Comment 18

[Paul Adenot (:padenot)]

This is orange on try, but I think 962719 will fix the errors.

Comment 19

[Paul Adenot (:padenot)]

Attachment: Part 12 - Fix mozCaptureStream. r=

Hrm, I forgot that I had added this after asking for all the reviews.

Comment 20

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8653521 [details] [diff] [review]
Part 12 - Fix mozCaptureStream. r=

Review of attachment 8653521 [details] [diff] [review]:
-----------------------------------------------------------------

One of these in CaptureStreamInternal() should suffice.

Comment 21

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/905d5f8b66c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/865b6a377448
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a303a9f74f8
https://hg.mozilla.org/integration/mozilla-inbound/rev/23e4bbe07e4c
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9856dc51513
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8264b7c691
https://hg.mozilla.org/integration/mozilla-inbound/rev/47c3d22006d9
https://hg.mozilla.org/integration/mozilla-inbound/rev/c944b51c50d7
https://hg.mozilla.org/integration/mozilla-inbound/rev/58786af75f6a
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d6a18652417
https://hg.mozilla.org/integration/mozilla-inbound/rev/192e65f2ddc2
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2415cfb538

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/905d5f8b66c2
https://hg.mozilla.org/mozilla-central/rev/865b6a377448
https://hg.mozilla.org/mozilla-central/rev/1a303a9f74f8
https://hg.mozilla.org/mozilla-central/rev/23e4bbe07e4c
https://hg.mozilla.org/mozilla-central/rev/e9856dc51513
https://hg.mozilla.org/mozilla-central/rev/4d8264b7c691
https://hg.mozilla.org/mozilla-central/rev/47c3d22006d9
https://hg.mozilla.org/mozilla-central/rev/c944b51c50d7
https://hg.mozilla.org/mozilla-central/rev/58786af75f6a
https://hg.mozilla.org/mozilla-central/rev/7d6a18652417
https://hg.mozilla.org/mozilla-central/rev/192e65f2ddc2
https://hg.mozilla.org/mozilla-central/rev/ec2415cfb538