1190681 - Browser extension |notifications| API needs support for buttons in notifications

Status: NEW

(WebExtensions :: Frontend, enhancement, P3)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This will require some toolkit support.

Comment 1

[Andy McKay]

I'm not sure this is a P1 (it was filed as such a year ago), Bob did we have some tracking bugs for what needs to happen to allow this to work?

Comment 2

[Bob Silverberg [:bsilverberg]]

This is required for Chrome parity, but I agree that it may not be a P1. Native work is required to update nsIAlertsService to support the buttons. It doesn't look like a bug has been opened for that, so I created bug 1286536 and have marked it as blocking this bug. There are a few other things that we don't seem to support from chrome.notifications, such as notifications with multiple items, notifications which report progress, and the `requireInteraction` option [1]. I'm not sure where we stand on implementing those or not. Kris, do you have any thoughts on those?

[1] https://developer.chrome.com/extensions/notifications#type-NotificationOptions

Comment 3

[Andy McKay]

Thanks for adding the blocking bug. Agree, its not a P1 so dropping.

Comment 4

[Kris Maglione [:kmag]]

I agree that it doesn't seem like a huge priority at the moment, given the amount of platform work required. Let's look at it again in the next quarter, or when bug 1225110 is fixed.

Comment 6

[sankar88.aj]

Any tentative date to fix this bug ? I'll plan my web extension accordingly.

Comment 7

[Andrew Swan [:aswan]]

(In reply to sankar88.aj from comment #6)
> Any tentative date to fix this bug ? I'll plan my web extension accordingly.

No, the code that generates notifications (independent of webextensions) doesn't yet have support for buttons, so that needs to happen before the corresponding webextensions apis get implemented.  You can follow the dependent bug linked above, but it doesn't appear to be a high priority for anybody at the moment.

Comment 8

[Manish Jethani]

Now that all legacy add-ons are disabled in the Firefox nightly, maybe this should have a higher priority.

Adblock Plus (WebExtensions) falls back to Window.confirm if notifications with buttons are not supported, but that won't work for WebExtensions either because bug #1203394. There is currently no fallback available.

Comment 9

[Kuba Niewiarowski]

> There is currently no fallback available.

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/windows/create

Comment 10

[Manish Jethani]

Thanks, windows.create might work as a fallback. It's still not available on Android though.

Comment 11

[Jason Savard]

With the release of Firefox Quantum my Gmail extension could definitely use a notification button to quickly delete incoming emails, just as it does with my the Chrome version of the extension.

Comment 12

[Maciej Krüger]

Half a year later, still an issue. This doesn't seem to be blocked by anything.

Comment 13

[Worcester12345]

(In reply to Kris Maglione [:kmag] from comment #4)

I agree that it doesn't seem like a huge priority at the moment, given the
amount of platform work required. Let's look at it again in the next
quarter, or when bug 1225110 is fixed.

I think there has been some activity in that bug, so hopefully a patch will come along here soon.

Comment 14

[Will Ryan]

How is this still not implemented? Chrome has had this feature for years!