1190771 - [Dialer]When user makes a call and tap the number on dialer pad, the screen will not show the number we tapped.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Cola, OOO till Oct. 8th]

Attachment: logcat001.txt

[1.Description]:
[FlameKK v2.5][AriesKKv2.5][Dialer]The screen will not show the number we tapped, when user taps the number on dialer pad during a call.
Found at:17:28
See attachment:logcat001.txt, Aries_2.5_video.3gp

[2.Testing Steps]: 
1.Make a call like 10010.
2.When the call is connected, tap the number on dialer pad.

[3.Expected Result]: 
2.There will be a new page to show the number we tapped.

[4.Actual Result]: 
2.The page has no change.

[5.Reproduction build]: 
Device: Flame KK 2.2(Unaffected)
Build ID               20150803032504
Gaia Revision          f8b119ac30e97df991c97682ac4d4f9ca22e1793
Gaia Date              2015-07-31 13:20:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/429b9d2d4566
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150803.072845
Firmware Date          Mon Aug  3 07:28:58 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device:Flame KK 2.5(Affected)
Build ID               20150803150205
Gaia Revision          dbacf8364f4505d021b7d8fb9cabea325004dbcc
Gaia Date              2015-08-03 16:38:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abc56d57f6e1
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150803.183149
Firmware Date          Mon Aug  3 18:32:00 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Affected)
Build ID               20150801110932
Gaia Revision          2ca27bbdd84526c6a3b198d9cf10f2caff1dadde
Gaia Date              2015-07-31 08:23:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/32712cd01159
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150801.105449
Firmware Date          Sat Aug  1 10:54:56 UTC 2015
Bootloader             s1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Cola, OOO till Oct. 8th]

Attachment: Aries_2.5_video.3gp

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression that fails smoke tests, user doesn't have visual confirmation of dialing a new number

Requesting a window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.5
BuildID: 20150731154437
Gaia: a83366dc9f73182bb43d06b22337670aa5d71cb6
Gecko: 1e51e74f2de7
Version: 42.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Device: Flame 2.5
BuildID: 20150731163337
Gaia: 1a814a4e7fa57132cdc0512a6c363b6b9471431d
Gecko: afd2a51ce670
Version: 42.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko - no repro
Gaia: a83366dc9f73182bb43d06b22337670aa5d71cb6
Gecko: afd2a51ce670

Last Working Gecko First Broken Gaia - repro
Gaia: 1a814a4e7fa57132cdc0512a6c363b6b9471431d
Gecko: 1e51e74f2de7

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/a83366dc9f73182bb43d06b22337670aa5d71cb6...1a814a4e7fa57132cdc0512a6c363b6b9471431d

Caused by changes made in Bug 1104667.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Taking

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1190771-fix-replacing-phone-numer > mozilla-b2g:master

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8643272 [details] [review]
[gaia] zbraniecki:1190771-fix-replacing-phone-numer > mozilla-b2g:master

Etienne, can you take a look at this?

It's a regression from a recent patch and I believe that :gsvelto is on PTO so he can't fix it. Since i was helping him with the patch, I want to be on top of any regressions.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comms triage: Smoketest blocker.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8643272 [details] [review]
[gaia] zbraniecki:1190771-fix-replacing-phone-numer > mozilla-b2g:master

stamp :)

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/65941f31e9b6ce23b157c54e9f8a14566a344d0c

Comment 10

[Nicholas Nelson [:NicholasN]]

Verified fixed on latest Aries build

Actual Result:

Dial pad in call screen shows numbers tapped by user.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150806112625
Gaia: 497fe3f938722b0aa49c93f975fad5d9ed3b0a82
Gecko: 22476236b3e1
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Comment 11

[Shally Li（leave from Mozilla）]

Per comment 10, change the 'status-b2g-master' as 'verified'.