Move OwningNonNull to from dom/ to xpcom/

RESOLVED FIXED in Firefox 42

Status

()

Core
XPCOM
--
enhancement
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is more widely useful than just DOM.
Created attachment 8643018 [details] [diff] [review]
Patch
Attachment #8643018 - Flags: review?(nfroyd)
Comment on attachment 8643018 [details] [diff] [review]
Patch

Review of attachment 8643018 [details] [diff] [review]:
-----------------------------------------------------------------

I think you uploaded the wrong patch.
Attachment #8643018 - Flags: review?(nfroyd)
Created attachment 8643032 [details] [diff] [review]
Patch
Attachment #8643018 - Attachment is obsolete: true
Attachment #8643032 - Flags: review?(nfroyd)
Comment on attachment 8643032 [details] [diff] [review]
Patch

Review of attachment 8643032 [details] [diff] [review]:
-----------------------------------------------------------------

It would be great if you could fix the alphabetization of the headers in some of the files you modified, but since we don't have decent tools to do that, a follow-up bug for those is fine.
Attachment #8643032 - Flags: review?(nfroyd) → review+
I find :!sort in vim works well.  :)
NOTE TO SHERRIFFS: This patch changes the OwningNonNull.h header from mozilla/dom/OwningNonNull.h to mozilla/OwningNonNull.h, and moves the class out of the dom namespace.  So if any merged code has references to the old location/name, it will not build.  As an alternative to backing this patch out, you could just remove the "dom" bit.
Depends on: 1191305
https://hg.mozilla.org/mozilla-central/rev/ac4ab7680520
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.