Closed
Bug 1190823
Opened 9 years ago
Closed 9 years ago
Move OwningNonNull to from dom/ to xpcom/
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file, 1 obsolete file)
37.21 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
This is more widely useful than just DOM.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8643018 -
Flags: review?(nfroyd)
Comment 2•9 years ago
|
||
Comment on attachment 8643018 [details] [diff] [review] Patch Review of attachment 8643018 [details] [diff] [review]: ----------------------------------------------------------------- I think you uploaded the wrong patch.
Attachment #8643018 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8643018 -
Attachment is obsolete: true
Attachment #8643032 -
Flags: review?(nfroyd)
Comment 4•9 years ago
|
||
Comment on attachment 8643032 [details] [diff] [review] Patch Review of attachment 8643032 [details] [diff] [review]: ----------------------------------------------------------------- It would be great if you could fix the alphabetization of the headers in some of the files you modified, but since we don't have decent tools to do that, a follow-up bug for those is fine.
Attachment #8643032 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 5•9 years ago
|
||
I find :!sort in vim works well. :)
Assignee | ||
Comment 6•9 years ago
|
||
Green build-only try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d9f880a4ae3
Assignee | ||
Comment 8•9 years ago
|
||
NOTE TO SHERRIFFS: This patch changes the OwningNonNull.h header from mozilla/dom/OwningNonNull.h to mozilla/OwningNonNull.h, and moves the class out of the dom namespace. So if any merged code has references to the old location/name, it will not build. As an alternative to backing this patch out, you could just remove the "dom" bit.
https://hg.mozilla.org/mozilla-central/rev/ac4ab7680520
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 10•9 years ago
|
||
Updated documentation at https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#OwningNonNull
You need to log in
before you can comment on or make changes to this bug.
Description
•