1190912 - Autophone - refactor tests to remove necessity for duplicating code

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Currently, too much functionality for setting configurations, pushing files to the devices, creating profiles, etc. was placed too far down the class hierarchy which requires new tests to either subclass an inappropriate test class or to duplicate code with minor changes. Once bug 1172105 lands, I want to take advantage of the opportunity to correct this architecture/design mistake on my part.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1190912-v1.patch

Test run for smoketest, s1s2-local, s1s2-remote, webappstartup, mochitest-media and tp4m-remote:

https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=1e1b1e7995c4&exclusion_profile=false&filter-searchStr=autophone

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8649695 [details] [diff] [review]
bug-1190912-v1.patch

Review of attachment 8649695 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great.  I focused more on the talos stuff, but the rest seem like a pretty straightforward and non intrusive refactor.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8649695 [details] [diff] [review]
bug-1190912-v1.patch

Review of attachment 8649695 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I can't find anything wrong with this. :)

I like the refactoring.

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/a1584c9634747505723e6497298a1315c026eba3