1191055 - [skiplist] Put "pages_commit" on the skip list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[alex_mayorga]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1128170#c87

(In reply to David Major [:dmajor] from comment #87)
> "moz_abort | pages_commit" is a generic signature. The graphics issue in
> this bug was just one way to reach it. There are many other ways to fail in
> that function and they are most likely unrelated to this bug.
> 
> We should put "pages_commit" on the skip list so that failures can be
> correctly attributed to the callers. I'll file a skiplist bug when I have
> some spare time, but if anyone can do it faster, feel free!

Comment 1

[Peter Bengtsson [:peterbe]]

Who adds things to the skiplist?

Comment 2

[Lonnen :lonnen]

Anyone really -- see: https://github.com/mozilla/socorro/commit/373dd547e46833502141991d7845fa2d67dec661

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 to do soon. It's an easy fix.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping this bug to the signature component.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Some recent sample crashes:

16254b3e-4458-4666-aaff-4f9110180109
72ab7561-1770-4bfd-bd04-15b8f0180109

Adding "pages_commit" to the prefix list yields this:

app@processor:/app$ python -m socorro.signature 16254b3e-4458-4666-aaff-4f9110180109 72ab7561-1770-4bfd-bd04-15b8f0180109
Crash id: 16254b3e-4458-4666-aaff-4f9110180109
Original: pages_commit
New:      pages_commit | chunk_recycle
Same?:    False

Crash id: 72ab7561-1770-4bfd-bd04-15b8f0180109
Original: moz_abort | pages_commit
New:      moz_abort | pages_commit | chunk_recycle
Same?:    False


David, alex: Is that helpful? Should we add "chunk_recycle", too?

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this.

Comment 7

[(Away)]

> New:      pages_commit | chunk_recycle
> New:      moz_abort | pages_commit | chunk_recycle

chunk_recycle is still within the memory allocator, so we still won't know what Gecko code called this.

Could you please later/rinse/repeat until the functions get out of mozglue.dll?

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sounds like you're saying, "Yes--add chunk_recycle, too".

Adding that, produces the following:

app@processor:/app$ python -m socorro.signature 16254b3e-4458-4666-aaff-4f9110180109 72ab7561-1770-4bfd-bd04-15b8f0180109
Crash id: 16254b3e-4458-4666-aaff-4f9110180109
Original: pages_commit
New:      pages_commit | chunk_recycle | chunk_alloc
Same?:    False

Crash id: 72ab7561-1770-4bfd-bd04-15b8f0180109
Original: moz_abort | pages_commit
New:      moz_abort | pages_commit | chunk_recycle | chunk_alloc
Same?:    False


Adding chunk_alloc, produces the following:

app@processor:/app$ python -m socorro.signature 16254b3e-4458-4666-aaff-4f9110180109 72ab7561-1770-4bfd-bd04-15b8f0180109
Crash id: 16254b3e-4458-4666-aaff-4f9110180109
Original: pages_commit
New:      pages_commit | chunk_recycle | chunk_alloc | arena_run_alloc | je_malloc | AllocTable
Same?:    False

Crash id: 72ab7561-1770-4bfd-bd04-15b8f0180109
Original: moz_abort | pages_commit
New:      moz_abort | pages_commit | chunk_recycle | chunk_alloc | arena_run_alloc | arena_bin_nonfull_run_get | je_malloc | nsTextFragment::SetTo
Same?:    False


I think that's as far as we should go with this bug.

I'll do a PR now.

Comment 9

[(Away)]

> New:      pages_commit | chunk_recycle | chunk_alloc | arena_run_alloc | je_malloc | AllocTable
> New:      moz_abort | pages_commit | chunk_recycle | chunk_alloc | arena_run_alloc | arena_bin_nonfull_run_get | je_malloc | nsTextFragment::SetTo

This sounds great, thank you!

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4282: fixes bug 1191055 - add pages_commit and friends to prefix list

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/707eb2caa51213bba2e95dd4d3ade1d48c50d758
fixes bug 1191055 - add pages_commit and friends to prefix list

This adds pages_commit, chunk_recycle, and chunk_alloc.

https://github.com/mozilla-services/socorro/commit/9e330d40bf5c1ebc5339fa58a1ca3d8c67f1690d
Merge pull request #4282 from willkg/1191055-pages-commit

fixes bug 1191055 - add pages_commit and friends to prefix list