Closed Bug 1191102 Opened 9 years ago Closed 9 years ago

Change all instances of Example to FramedExample in the ui-showcase

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla43
Iteration:
43.1 - Aug 24
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: andreio, Assigned: dcritchley)

References

Details

(Whiteboard: [tech-debt][visual refresh])

User Story

As a developer, views in the showcase apply CSS as they would production (without CSS cross-file contamination), so debugging is straightforward.

Acceptance criteria: all views are moved from <Example> to <FramedExample>

Tech checklist:
* replace each <Example> with <FramedExample>, possibly contained by a div with one of the classes in comment 1
* validate each replacement that it looks correct by comparing to the running code
* remove <Example> component definition
* see if it makes sense to optimize ui-showcase to not have to use the panel/fx-embedded/standalone containing div

Attachments

(1 file, 3 obsolete files)

Loop UI Showcase change from using <Example> to <FramedExample>
110.98 KB, patch
andreio
: review+
Details | Diff | Splinter Review
Need: Having FramedExamples (using iframes as containers for our components) helps contain CSS leakage.
Assignee: nobody → david.critchley
Blocks: 1179193
body class has, each in html file, a class on it which is used in CSS: panel.html: "panel" conversation.html: "fx-embedded" standalone: "standalone"
Rank: 15
User Story: (updated)
Flags: firefox-backlog+
Priority: -- → P1
Iteration: --- → 43.1 - Aug 24
Whiteboard: [tech-debt][visual refresh]
Comment on attachment 8647016 [details] [diff] [review] Loop UI Showcase change from using <Example> to <FramedExample> Review of attachment 8647016 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Let's see it with the Example component removed.
Attachment #8647016 - Flags: review?(andrei.br92) → review-
Attachment #8647016 - Attachment is obsolete: true
Attachment #8647039 - Flags: review?(andrei.br92)
Comment on attachment 8647039 [details] [diff] [review] Loop UI Showcase change from using <Example> to <FramedExample> Review of attachment 8647039 [details] [diff] [review]: ----------------------------------------------------------------- Almost there. Failing UI showcase tests due to warnings.
Attachment #8647039 - Flags: review?(andrei.br92) → review-
Attachment #8647039 - Attachment is obsolete: true
Attachment #8647051 - Flags: review?(andrei.br92)
Attachment #8647051 - Attachment is obsolete: true
Attachment #8647051 - Flags: review?(andrei.br92)
Attachment #8647058 - Flags: review?(andrei.br92)
Comment on attachment 8647058 [details] [diff] [review] Loop UI Showcase change from using <Example> to <FramedExample> Review of attachment 8647058 [details] [diff] [review]: ----------------------------------------------------------------- Great work. Thank you!
Attachment #8647058 - Flags: review?(andrei.br92) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/852c6333baee
Keywords: checkin-needed
Whiteboard: [tech-debt][visual refresh] → [tech-debt][visual refresh][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/852c6333baee
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Whiteboard: [tech-debt][visual refresh][fixed-in-fx-team] → [tech-debt][visual refresh]
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: