1191178 - Add PerformanceRenderTiming and PerformanceCompositeTiming webidl

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

This bug is split from bug 1158032.

I am going to use this bug to just add webidl files and their implementations.
This bug is not affected by PerformanceObserver implementation so incoming patches can be reviewed.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 0: Fix unified build failure

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 1: Add a function to check frame timing preference value

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 2: Add PerformanceRenderTiming and PerformanceCompositeTiming

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Filed https://github.com/w3c/frame-timing/issues/45

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Filed also https://github.com/w3c/frame-timing/issues/46, but since that is sort of an enhancement only, or simplification, that doesn't need to block this bug.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 0.1: Fix unified build failure caused by a patch for bug 992096

Unfortunately there is another unified build failure has been introduced by a patch for bug 992096 before checked-in.

This is a quick fix for the failure. I think GetSriLog() will move in one place though.

Comment 7

[François Marier [:francois]]

Comment on attachment 8649551 [details] [diff] [review]
Part 0.1: Fix unified build failure caused by a patch for bug 992096

Review of attachment 8649551 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Hiroyuki!

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 1: Add a function to check frame timing preference value v2

Rebased to master.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank you, Olli! And thank you, François!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=990b786f34e4

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7621c6af97e
https://hg.mozilla.org/integration/mozilla-inbound/rev/744bab15a5ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/85cb22235eb5
https://hg.mozilla.org/integration/mozilla-inbound/rev/32adb36cf863

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7621c6af97e
https://hg.mozilla.org/integration/mozilla-inbound/rev/744bab15a5ec
https://hg.mozilla.org/integration/mozilla-inbound/rev/85cb22235eb5
https://hg.mozilla.org/integration/mozilla-inbound/rev/32adb36cf863

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backing all of this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/42489ba95511 to see if that fixes the build bustage on inbound that looks like: https://treeherder.mozilla.org/logviewer.html#?job_id=13065542&repo=mozilla-inbound

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 0.2: Include nsBaseHashTable in nsScriptNameSpaceManager.h explicitly to avoid unified build errors.

Another unified build error is caused by another commit. I am not sure which one is exactly.

Nicholas, can you please take a look this?

And part 0 patch is also rotted by this change. https://hg.mozilla.org/mozilla-central/diff/3413e043886c/dom/base/StructuredCloneHelper.cpp
I will update a new rebased patch for part 0 soon.

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 0: Fix unified build failure v2

Rebased master, just dropped the change for StructuredCloneHelper.cpp.

Comment 15

[Nicholas Nethercote [inactive]]

Comment on attachment 8650215 [details] [diff] [review]
Part 0.2: Include nsBaseHashTable in nsScriptNameSpaceManager.h explicitly to avoid unified build errors.

Review of attachment 8650215 [details] [diff] [review]:
-----------------------------------------------------------------

nsScriptNameSpaceManager.h doesn't use anything from nsBaseHashtable.h, or at least not that I can see.

Can you copy and paste the compiler error you're getting without this change? I suspect there might be a better way of fixing it. Thanks.

Comment 16

[Hiroyuki Ikezoe (:hiro)]

(In reply to Nicholas Nethercote [:njn] from comment #15)

> Can you copy and paste the compiler error you're getting without this
> change? I suspect there might be a better way of fixing it. Thanks.

Here it is:

/home/zoe/mozilla-central/dom/base/nsScriptNameSpaceManager.h:182:11: error: unknown type name 'PLDHashOperator'
  typedef PLDHashOperator

Thank you,

Comment 17

[Nicholas Nethercote [inactive]]

Comment on attachment 8650215 [details] [diff] [review]
Part 0.2: Include nsBaseHashTable in nsScriptNameSpaceManager.h explicitly to avoid unified build errors.

Review of attachment 8650215 [details] [diff] [review]:
-----------------------------------------------------------------

My mistake; this is right way to do it. Thank you for the extra information.

Comment 18

[Hiroyuki Ikezoe (:hiro)]

np, thanks for quick reviewing!

Comment 19

[Hiroyuki Ikezoe (:hiro)]

Attachment: Part 2: Add PerformanceRenderTiming and PerformanceCompositeTiming v2

Unfortunately part 2 has been also rotted.

I pushed try now.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27c8e27d265f

Comment 20

[Hiroyuki Ikezoe (:hiro)]

Try result looks good.

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9af7b64ce376
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cbac83b3cc3
https://hg.mozilla.org/integration/mozilla-inbound/rev/fae4800f7592
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c322cc709b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3166fee2220

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9af7b64ce376
https://hg.mozilla.org/mozilla-central/rev/4cbac83b3cc3
https://hg.mozilla.org/mozilla-central/rev/fae4800f7592
https://hg.mozilla.org/mozilla-central/rev/4c322cc709b1
https://hg.mozilla.org/mozilla-central/rev/e3166fee2220

Comment 23

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8649738 [details] [diff] [review]
Part 1: Add a function to check frame timing preference value v2

>+  Preferences::AddBoolVarCache(&sIsFrameTimingPrefEnabled,
>+                               "dom.enable_frame_timing", true);
>+

Sorry, I didn't notice this. We should default to false here.

Comment 24

[Jean-Yves Perrier [:teoli]]

Nothing to document here anymore as this has been removed in bug 1271846.