Closed Bug 1191212 Opened 4 years ago Closed 4 years ago

make[3]: *** [libnpsecondtest.so] Error 1 when switching Gtk+3

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With all the back and forth in bug 1186748, the fact that there are still parts to land, and combined fact that CLOBBER is not fine-grained, each time one platform is Gtk+3 enabled, we're requiring a global clobber, and that sucks.

The root for this particular error is:

for a working build:
$ curl -s http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/1438642915/mozilla-inbound-linux64-valgrind-bm91-build1-build204.txt.gz | zgrep MOZ_GTK2_LIBS
checking MOZ_GTK2_LIBS... -L/builds/slave/m-in-l64-valgrind-000000000000/src/gtk3/usr/local/lib -L/builds/slave/m-in-l64-valgrind-000000000000/src/gtk3/usr/lib64 -lgtk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lfreetype -lfontconfig -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lcairo 

for a broken build:
$ curl -s http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/1438640819/mozilla-inbound-linux64-valgrind-bm71-build1-build408.txt.gz | zgrep MOZ_GTK2_LIBS
checking MOZ_GTK2_LIBS... -L/builds/slave/m-in-l64-valgrind-000000000000/src/gtk3/usr/local/lib

Sounds like something wrong in configure's m4 or shell.
And the reason is:

for a working build:
$ curl -s http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/1438642915/mozilla-inbound-linux64-valgrind-bm91-build1-build204.txt.gz | zgrep "checking for pkg-config"
checking for pkg-config... /builds/slave/m-in-l64-valgrind-000000000000/src/gtk3/usr/local/bin/pkg-config

for a broken build:
$ curl -s http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/1438640819/mozilla-inbound-linux64-valgrind-bm71-build1-build408.txt.gz | zgrep "checking for pkg-config"
checking for pkg-config... (cached) /usr/bin/pkg-config
When switching between Gtk+3 and Gtk+2, config.cache will contain a PKG_CONFIG
that may not be suitable for the build:
- after a Gtk+2 build, config.cache will point to the system pkg-config, which
  doesn't like the pkg-config files in the Gtk+3 tooltool package.
- after a Gtk+3 build, config.cache will point to the Gtk+3 tooltool package's
  pkg-config, which is likely not there in a Gtk+2 build.

Setting PKG_CONFIG avoids all config.cache considerations altogether, so set it
appropriately for both cases.
Assignee: nobody → mh+mozilla
Attachment #8643577 - Flags: review?(mshal)
Attachment #8643577 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/efd7ad55b0df
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
url:        https://hg.mozilla.org/comm-central/rev/655dcbac8fae72185edcfbbe15b4792d1d40ab91
changeset:  655dcbac8fae72185edcfbbe15b4792d1d40ab91
user:       aleth <aleth@instantbird.org>
date:       Sat Aug 08 00:47:37 2015 +0200
description:
Keep build/ in sync following bug 1191212. rs=bustage-fix
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.