1191306 - Various translation tests are going to permafail when Gecko 42 merges to Aurora

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

.includes is only enabled on nightly. This needs attention ASAP as the uplift is next Monday.

https://treeherder.mozilla.org/logviewer.html#?job_id=9857404&repo=try

07:58:17 INFO - 884 INFO TEST-UNEXPECTED-FAIL | browser/components/translation/test/browser_translation_fhr.js | Uncaught exception - at resource:///modules/translation/Translation.jsm:113 - TypeError: Object.keys(...).includes is not a function

Comment 1

[Iaroslav Sheptykin]

Thanks Ryan! I am looking at it. I will submit a patch ASAP.

Comment 2

[Iaroslav Sheptykin]

Attachment: Replacing .includes with indexOf to avoid test failures on Aurora

Hi guys! Here is a quick fix. I replaced the use of .include with indexOf. Tests pass locally with nightly, but I don't know how to test this properly against an Aurora build.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

If it passes locally, you should be fine. AFAIK, indexOf isn't restricted :)

Comment 4

[Iaroslav Sheptykin]

It does, but I now have to clobber-rebuild firefox and try again to sure. compiling ...

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8643740 [details] [diff] [review]
Replacing .includes with indexOf to avoid test failures on Aurora

Review of attachment 8643740 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Iaroslav for the quick fix!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/214d9846a4db

Comment 7

[Iaroslav Sheptykin]

Hey Felipe! Thanks for landing the patch. Sorry, for braking Aurora :)

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Hi Iaroslav! Thank you for writing the fix. And no problem, Ryan noticed that on time, Aurora was unharmed :) I didn't know either that .includes is limited to Nightly-only for now

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/214d9846a4db

Comment 10

[Ryan VanderMeulen [:RyanVM]]

In the future, please hold off on resolving bugs until they land on mozilla-central. For the most part, this should be done automatically for you.

Comment 11

[Iaroslav Sheptykin]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> In the future, please hold off on resolving bugs until they land on
> mozilla-central. For the most part, this should be done automatically for
> you.

My fault, Ryan! I though that as soon as things land in fx-team the bug is done. I will be careful in the future.