Various translation tests are going to permafail when Gecko 42 merges to Aurora

VERIFIED FIXED in Firefox 42

Status

()

defect
--
critical
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: yarik.sheptykin)

Tracking

unspecified
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

Attachments

(1 attachment)

.includes is only enabled on nightly. This needs attention ASAP as the uplift is next Monday.

https://treeherder.mozilla.org/logviewer.html#?job_id=9857404&repo=try

07:58:17 INFO - 884 INFO TEST-UNEXPECTED-FAIL | browser/components/translation/test/browser_translation_fhr.js | Uncaught exception - at resource:///modules/translation/Translation.jsm:113 - TypeError: Object.keys(...).includes is not a function
Flags: needinfo?(yarik.sheptykin)
Thanks Ryan! I am looking at it. I will submit a patch ASAP.
Flags: needinfo?(yarik.sheptykin)
Assignee: nobody → yarik.sheptykin
Hi guys! Here is a quick fix. I replaced the use of .include with indexOf. Tests pass locally with nightly, but I don't know how to test this properly against an Aurora build.
Attachment #8643740 - Flags: review?(felipc)
If it passes locally, you should be fine. AFAIK, indexOf isn't restricted :)
It does, but I now have to clobber-rebuild firefox and try again to sure. compiling ...
Comment on attachment 8643740 [details] [diff] [review]
Replacing .includes with indexOf to avoid test failures on Aurora

Review of attachment 8643740 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Iaroslav for the quick fix!
Attachment #8643740 - Flags: review?(felipc) → review+
Hey Felipe! Thanks for landing the patch. Sorry, for braking Aurora :)
Hi Iaroslav! Thank you for writing the fix. And no problem, Ryan noticed that on time, Aurora was unharmed :) I didn't know either that .includes is limited to Nightly-only for now
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
In the future, please hold off on resolving bugs until they land on mozilla-central. For the most part, this should be done automatically for you.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 42
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> In the future, please hold off on resolving bugs until they land on
> mozilla-central. For the most part, this should be done automatically for
> you.

My fault, Ryan! I though that as soon as things land in fx-team the bug is done. I will be careful in the future.
You need to log in before you can comment on or make changes to this bug.