1191335 - Add a "Learn More" link to HPKP security console messages

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[:Cykesiopka]

(J. Ryan Stinnett [:jryans] (use ni?) from Bug 1124649 comment #20)
> It looks like for STS, we add a "Learn More" link to the console output[1].
> 
> It would be nice to link to such a page for PKP errors too, perhaps [this
> page][2].
> 
> [1]:
> https://dxr.allizom.org/mozilla-central/rev/
> abc56d57f6e1aebade48949fb557d26eae555df8/browser/devtools/webconsole/
> webconsole.js#1679
> [2]: https://developer.mozilla.org/en-US/docs/Web/Security/Public_Key_Pinning

Comment 1

[:Cykesiopka]

keeler: Is https://developer.mozilla.org/docs/Web/Security/Public_Key_Pinning OK to point to at the moment?

The contents look good to me, but I'm not sure if we want a "Learn More" link to point to page that's "in need of a technical review" and "in need of an editorial review".

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

That page looks pretty good to me. I did fix a couple of grammar nits. Apparently I have the ability to say that a technical and editorial review has been completed, so I went ahead and did that. It should be fine to link to, now.

Comment 3

[:Cykesiopka]

Attachment: MozReview Request: Bug 1191335 - Add a "Learn More" link to HPKP security console messages.

Bug 1191335 - Add a "Learn More" link to HPKP security console messages.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8645516 [details]
MozReview Request: Bug 1191335 - Add a "Learn More" link to HPKP security console messages.

https://reviewboard.mozilla.org/r/15519/#review13965

Ship It!

Comment 5

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f27cb523d16f
https://treeherder.mozilla.org/#/jobs?repo=try&revision=71f1d74abe8e

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9300342ec9f0

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9300342ec9f0