Add a "Learn More" link to HPKP security console messages

RESOLVED FIXED in Firefox 43

Status

DevTools
Console
RESOLVED FIXED
3 years ago
a month ago

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

Tracking

unspecified
Firefox 43

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
(J. Ryan Stinnett [:jryans] (use ni?) from Bug 1124649 comment #20)
> It looks like for STS, we add a "Learn More" link to the console output[1].
> 
> It would be nice to link to such a page for PKP errors too, perhaps [this
> page][2].
> 
> [1]:
> https://dxr.allizom.org/mozilla-central/rev/
> abc56d57f6e1aebade48949fb557d26eae555df8/browser/devtools/webconsole/
> webconsole.js#1679
> [2]: https://developer.mozilla.org/en-US/docs/Web/Security/Public_Key_Pinning
(Assignee)

Comment 1

3 years ago
keeler: Is https://developer.mozilla.org/docs/Web/Security/Public_Key_Pinning OK to point to at the moment?

The contents look good to me, but I'm not sure if we want a "Learn More" link to point to page that's "in need of a technical review" and "in need of an editorial review".
Flags: needinfo?(dkeeler)
That page looks pretty good to me. I did fix a couple of grammar nits. Apparently I have the ability to say that a technical and editorial review has been completed, so I went ahead and did that. It should be fine to link to, now.
Flags: needinfo?(dkeeler)
(Assignee)

Comment 3

3 years ago
Created attachment 8645516 [details]
MozReview Request: Bug 1191335 - Add a "Learn More" link to HPKP security console messages.

Bug 1191335 - Add a "Learn More" link to HPKP security console messages.
Attachment #8645516 - Flags: review?(jryans)
Attachment #8645516 - Flags: review?(jryans) → review+
Comment on attachment 8645516 [details]
MozReview Request: Bug 1191335 - Add a "Learn More" link to HPKP security console messages.

https://reviewboard.mozilla.org/r/15519/#review13965

Ship It!
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/9300342ec9f0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.