1191376 - request: always show toolbar when restoring app

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

My most frequent use case for Firefox is launching it quickly to search for something or load a specific page by URL (either in the clipboard, in my memory, or less frequently, from my history).

I tend to sometimes keep tabs open to refer to later, but most of the times I launch the app I don't want to deal with them and just want a blank slate.

When Firefox launches, depending on what I was doing last, sometimes the top toolbar is collapsed. So I need to do a bit of a "wiggle" (scroll the page slightly) to get it to appear, then tap the location bar, then start typing. Ideally, I would never have to do that wiggle. If the toolbar always appeared after a restore then I wouldn't have to.

(There may very well be better ways to optimize this particular use case, of course, so feel free to dupe away to a more general bug about that.)

Comment 1

[Maurya Talisetti]

Is there a mentor for this bug? I have some changes that might benefit from a review: https://pastebin.mozilla.org/8869143

Essentially, the scenario doesn't exist when the is relaunched after a termination. The scenario exists only when the app is brought back to the foreground from the background. The above changes work as expected. However, in terms of code quality, I thought there might be improvements since I'm accessing the BrowserViewController and BrowserScrollController from the AppDelegate. Any suggestions anyone?

Comment 2

[Stephan Leroux [:sleroux]]

> However, in terms of code quality, I thought there might be improvements since I'm accessing the BrowserViewController and BrowserScrollController from the AppDelegate. Any suggestions anyone?

Eventually I'd like to see us eliminate as much of the coupling between the AppDelegate/BVC as we can. iOS sends out notifications that anyone can listen to for the various foreground/background events. The BVC already listens to these for hiding/showing web content when backgrounding the app while viewing a private tab [1]. Maybe try moving this logic here?

[1] https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L246

Comment 3

[Maurya Talisetti]

Attachment: Pull request

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8747684 [details] [review]
Pull request

Great, simple fix. Thanks for the patch!

Comment 5

[Stephan Leroux [:sleroux]]

master c9d67a4aea23ec93880fdd6085352222a351eb06

Comment 6

[Catalin Suciu [:csuciu]]

Verified as fixed latest master (0da9bd79).