119147 - [FIX]make fails: `aChromeURL' undeclared in mozilla/gfx/src/qt/nsDeviceContextSpecQT.cpp, line 193

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Walter Haidinger]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:0.9.7+) Gecko/20020108
BuildID:    2002011000

I've already posted this to netscape.public.mozilla.builds
(http://groups.google.com/groups?hl=en&group=netscape.public.mozilla.builds&selm=f8438374.0201080954.65f310e6%40posting.google.com)
but the bug still persists, so here goes.

With source pulled from scratch with cvs 
(checkout start: Thu Jan 10 01:33:47 CET 2002)
building Mozilla fails:

nsDeviceContextSpecQT.cpp:193: `aChromeURL' undeclared (first use this function)
nsDeviceContextSpecQT.cpp:193: (Each undeclared identifier is reported only once
nsDeviceContextSpecQT.cpp:193: for each function it appears in.)
make[4]: *** [nsDeviceContextSpecQT.o] Error 1
make[4]: Leaving directory `/usr/local/src/browsers/mozilla/cvs/mozilla/gfx/src/qt'

Line 193 of nsDeviceContextSpecQT.cpp reads:
   rv = wwatch->OpenWindow(parent, aChromeURL,

Please note that the same line looks like as follows in the 0.9.7 source tree:
   rv = wwatch->OpenWindow(parent,
       "chrome://global/content/printdialog.xul",

Therefore, since aChromeURL isn't defined anywhere, adding 
(e.g. to mozilla/cvs/mozilla/gfx/src/qt/nsDeviceContextSpecQT.h)

  #define aChromeURL "chrome://global/content/printdialog.xul"

makes Mozilla build successfully.




Reproducible: Always
Steps to Reproduce:
1. configure with .mozconfig (see below)
2. make
3.

Actual Results:  build fails

Expected Results:  build succeeds

My .mozconfig:

# Options for 'configure' (same as command-line options).
ac_add_options --enable-toolkit-gtk
ac_add_options --enable-toolkit-xlib
ac_add_options --enable-toolkit-qt
ac_add_options --with-qtdir=/usr/lib/qt2
ac_add_options --enable-crypto
ac_add_options --disable-debug
ac_add_options --enable-optimize
ac_add_options --enable-strip

Build environment:
Linux(x86), Kernel 2.4.17 and SuSE 7.3 (with qt-2.3.1 packages)

Comment 1

[hacker formerly known as [e-mail]]

Over to rods as this was part of the XP Print dialog landing.  

Comment 2

[rods (gone)]

Index: nsDeviceContextSpecQT.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/qt/nsDeviceContextSpecQT.cpp,v
retrieving revision 1.18
diff -u -r1.18 nsDeviceContextSpecQT.cpp
--- nsDeviceContextSpecQT.cpp   1 Jan 2002 12:58:48 -0000       1.18
+++ nsDeviceContextSpecQT.cpp   10 Jan 2002 19:32:02 -0000
@@ -190,7 +190,7 @@
       nsCOMPtr<nsIDOMWindowInternal> parent = do_QueryInterface(active);

       nsCOMPtr<nsIDOMWindow> newWindow;
-      rv = wwatch->OpenWindow(parent, aChromeURL,
+      rv = wwatch->OpenWindow(parent, "chrome://global/content/printdialog.xul"
,
             "_blank", "chrome,modal,centerscreen", array,
             getter_AddRefs(newWindow));
     }

Comment 3

[Marc Attinasi]

sr=attinasi for the string constant (assuming that a cstring is adequate here,
vs a NS_LITERAL_STRING).

Comment 4

[dcone (gone)]

r=dcone

Comment 5

[rods (gone)]

fixed

Comment 6

[sujay]

Walter, please verify and mark verified-fixed....thanks

Comment 7

[Walter Haidinger]

As requested: Verified and fixed. No problems compiling.