1191531 - ARM64: Implement AtomicsOperations

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Fill-in-AtomicOperations-arm64.h-assuming-a-modern-c.patch

Fills in jit/arm64/AtomicOperations-arm64.h. Since ARM64 requires the use of a modern compiler, the code just assumes the availability of __atomic_foo.

Fixes:
asm.js/testAtomics.js
asm.js/testAtomic-effect.js
asm.js/testBug1164931.js
asm.js/testBug1183060.js
atomics/optimization-tests.js
atomics/basic-tests.js

Comment 1

[Lars T Hansen [:lth]]

Comment on attachment 8643973 [details] [diff] [review]
0001-Fill-in-AtomicOperations-arm64.h-assuming-a-modern-c.patch

Review of attachment 8643973 [details] [diff] [review]:
-----------------------------------------------------------------

Yes.  For extra credit, add these assertions to the start of isLockfree8:

    MOZ_ASSERT(__atomic_always_lock_free(sizeof(int8_t), 0));
    MOZ_ASSERT(__atomic_always_lock_free(sizeof(int16_t), 0));
    MOZ_ASSERT(__atomic_always_lock_free(sizeof(int32_t), 0));

The reason is that I don't want somebody to accidentally copy this code to a platform where those don't hold and not discover it.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47e690b422fa

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47e690b422fa