Closed
Bug 1191552
Opened 10 years ago
Closed 10 years ago
ARM64: Move some common LIR to shared code
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
References
Details
Attachments
(1 file)
23.77 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Moves around some things that are trivially shareable.
22 files changed, 101 insertions(+), 349 deletions(-)
Attachment #8643997 -
Flags: review?(nicolas.b.pierron)
Comment 1•10 years ago
|
||
Comment on attachment 8643997 [details] [diff] [review]
0001-Move-common-lowering-functions-to-shared-code.patch
Review of attachment 8643997 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, I am happy that you notice these while working on the ARM64 backend, this reduce the overhead for adding new backends and reduce the overhead on reviewers :)
This patch contains 3 parts (LBox, LPowHalfD, Prologue & Epilogue), try to make multiple smaller patches in the future. ;)
Attachment #8643997 -
Flags: review?(nicolas.b.pierron) → review+
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•