1191608 - CanvasRenderingContext2D::DrawImage can read uninitialized pointer

Status: RESOLVED FIXED

(Core :: Canvas: 2D, defect)

Description

[Eric Rahm [:erahm]]

Coverity indicates that it's possible that in |CanvasRenderingContext2D::DrawImage|, |element| [1] is compared to another pointer when uninitialized [2].

[1] https://dxr.mozilla.org/mozilla-central/rev/5cf4d2f7f2f2b3df2f1edd31b8bdce7882f3875c/dom/canvas/CanvasRenderingContext2D.cpp#4271
[2] https://dxr.mozilla.org/mozilla-central/rev/5cf4d2f7f2f2b3df2f1edd31b8bdce7882f3875c/dom/canvas/CanvasRenderingContext2D.cpp#4505

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: initialize element to null in CanvasRenderingContext2D::DrawImage

This just initializes element to null, so that in places where it is not needed/assigned, it doesn't have a random garbage value.

Comment 2

[Lee Salzman [:lsalzman]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c3c9c7875b3

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/106c0863db60

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/106c0863db60