1191619 - Support extensions with no packaged manifest.webapp

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: no-webapp-addons.patch

This patch applies on top of bug 1190995.

It provides the capability to install zips that just have a manifest.json, and in this case checks that this is a chrome extension manifest and synthesize a webapp manifest.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8644593 [details] [diff] [review]
no-webapp-addons.patch

Review of attachment 8644593 [details] [diff] [review]:
-----------------------------------------------------------------

Gregor, do you mind reviewing while ferjm is on pto?

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 8644593 [details] [diff] [review]
no-webapp-addons.patch

Review of attachment 8644593 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/Webapps.jsm
@@ +3828,5 @@
>      let isLangPack = newManifest.role === "langpack" &&
>                       (aIsSigned || allowUnsignedLangpack);
>  
> +    let isAddon = newManifest.role === "addon" &&
> +                     (aIsSigned || AppsUtils.allowUnsignedAddons);

Nit: indentation
Where does allowUnsignedAddons get set? Is this only for testing?

::: dom/apps/tests/addons/update.webapp
@@ +5,1 @@
>    "package_path" : "application.zip"

Shouldn't we test an invalid manifest file as well somehow?

Comment 4

[[:fabrice] Fabrice Desré]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> Comment on attachment 8644593 [details] [diff] [review]
> no-webapp-addons.patch
> 
> Review of attachment 8644593 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/apps/Webapps.jsm
> @@ +3828,5 @@
> >      let isLangPack = newManifest.role === "langpack" &&
> >                       (aIsSigned || allowUnsignedLangpack);
> >  
> > +    let isAddon = newManifest.role === "addon" &&
> > +                     (aIsSigned || AppsUtils.allowUnsignedAddons);
> 
> Nit: indentation
> Where does allowUnsignedAddons get set? Is this only for testing?

Yes, we have a SpecialPowers function for that.

> ::: dom/apps/tests/addons/update.webapp
> @@ +5,1 @@
> >    "package_path" : "application.zip"
> 
> Shouldn't we test an invalid manifest file as well somehow?

Indeed, I'll add that before landing.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/2a5669be7ee3

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/33055236649c

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/54f3e2979aa2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/54f3e2979aa2