Closed Bug 1191684 Opened 4 years ago Closed 4 years ago

Remove unnecessary calls to NotifyAll() on the decoder monitor

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

https://hg.mozilla.org/try/rev/f90ff0c3fc79#l2.33
https://treeherder.mozilla.org/#/jobs?repo=try&revision=253c468796a8

A simple test shows that no one calls Wait() on the decoder monitor (We purposefully crash when Wait() is called on the decoder monitor). We are now safe to remove calls to NotifyAll() on the decoder monitor.
was there ever anything waiting on the monitor ?

I've been at Mozilla for one year, and I don't think that I ever saw anything waiting on it.
No one is waiting. The test in comment 0 proves it unless there are some code paths not exercised by our tests.
Oh yes. There used to some code waiting for the decoder monitor. I need to dig the hg logs.
Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().
Attachment #8644745 - Flags: review?(cpearce)
Attachment #8644745 - Flags: review?(cpearce) → review+
Comment on attachment 8644745 [details]
MozReview Request: Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

https://reviewboard.mozilla.org/r/15325/#review13889

Nice.
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/f77ab4c12d92
Assignee: nobody → jwwang
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.