1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/try/rev/f90ff0c3fc79#l2.33
https://treeherder.mozilla.org/#/jobs?repo=try&revision=253c468796a8

A simple test shows that no one calls Wait() on the decoder monitor (We purposefully crash when Wait() is called on the decoder monitor). We are now safe to remove calls to NotifyAll() on the decoder monitor.

Comment 1

[Jean-Yves Avenard [:jya]]

was there ever anything waiting on the monitor ?

I've been at Mozilla for one year, and I don't think that I ever saw anything waiting on it.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

No one is waiting. The test in comment 0 proves it unless there are some code paths not exercised by our tests.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Oh yes. There used to some code waiting for the decoder monitor. I need to dig the hg logs.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/rev/5b59618f0c34#l1.38

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Try looks green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=695b488a292b

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8644745 [details]
MozReview Request: Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

https://reviewboard.mozilla.org/r/15325/#review13889

Nice.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f77ab4c12d92

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f77ab4c12d92