bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Remove unnecessary calls to NotifyAll() on the decoder monitor

RESOLVED FIXED in Firefox 42

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
https://hg.mozilla.org/try/rev/f90ff0c3fc79#l2.33
https://treeherder.mozilla.org/#/jobs?repo=try&revision=253c468796a8

A simple test shows that no one calls Wait() on the decoder monitor (We purposefully crash when Wait() is called on the decoder monitor). We are now safe to remove calls to NotifyAll() on the decoder monitor.
was there ever anything waiting on the monitor ?

I've been at Mozilla for one year, and I don't think that I ever saw anything waiting on it.
(Assignee)

Comment 2

3 years ago
No one is waiting. The test in comment 0 proves it unless there are some code paths not exercised by our tests.
(Assignee)

Comment 3

3 years ago
Oh yes. There used to some code waiting for the decoder monitor. I need to dig the hg logs.
(Assignee)

Comment 6

3 years ago
Created attachment 8644745 [details]
MozReview Request: Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().
Attachment #8644745 - Flags: review?(cpearce)
Attachment #8644745 - Flags: review?(cpearce) → review+
Comment on attachment 8644745 [details]
MozReview Request: Bug 1191684 - Remove unnecessary calls to NotifyAll() on the decoder monitor since no one calls Wait().

https://reviewboard.mozilla.org/r/15325/#review13889

Nice.
(Assignee)

Comment 8

3 years ago
Thanks for the review.
https://hg.mozilla.org/mozilla-central/rev/f77ab4c12d92
Assignee: nobody → jwwang
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.