1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

As a parent I'd like to prevent my kid from sharing location, camera or microphone with a website. We should introduce a configurable restriction for the parent.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

@Sam: I'm pretty sure there are a bunch of parents that would like to restrict this. Maybe we should think of this when planning v2?

Comment 2

[Sam Fang [:sfang]]

(In reply to Sebastian Kaspari (:sebastian) from comment #1)
> @Sam: I'm pretty sure there are a bunch of parents that would like to
> restrict this. Maybe we should think of this when planning v2?

Yes I agree!

For V1 we just have the "Hide all location services features and related UI".
Parent would definitely need config like camera and microphone as well. :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sam Fang [:sfang] from comment #2)
> For V1 we just have the "Hide all location services features and related UI".
> Parent would definitely need config like camera and microphone as well. :)

The V1 bug was just about the Mozilla Location Service as far as I know (Settings -> Mozilla -> Mozilla Location Service). So sharing a location with for example Google Maps is still possible.

Comment 4

[Sam Fang [:sfang]]

(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> (In reply to Sam Fang [:sfang] from comment #2)
> > For V1 we just have the "Hide all location services features and related UI".
> > Parent would definitely need config like camera and microphone as well. :)
> 
> The V1 bug was just about the Mozilla Location Service as far as I know
> (Settings -> Mozilla -> Mozilla Location Service). So sharing a location
> with for example Google Maps is still possible.

Oh I see, that's good to know! Thanks :)

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Doorhanger

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Snackbar

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Default (Not blocked)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

I wonder what's the best way to show this blocked state to the user. I attached to examples (Doorhanger and Snackbar). Also I'm not sure about the best wording here (Possible variations: Camera, Microphone, Camera and microphone).

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

This makes sense to me. 

We should follow what we currently do for comment 7 (the unblocked state)

But for comment 5 and comment 6 (the blocked states), I'd suggest even more direct strings. :)

Snackbar and Doorhanger:

Camera/ Microphone/ Camera and microphone has been blocked.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: access_blocked.png

I just implemented the doorhanger (and not the Snackbar) because it opens automatically when a website requests access to microphone or camera.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites. r?ally

Bug 1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites. r?ally

Comment 12

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8685426 [details]
access_blocked.png

+!

Comment 13

[Allison Naaktgeboren :ally]

Comment on attachment 8685428 [details]
MozReview Request: Bug 1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites. r?ally

https://reviewboard.mozilla.org/r/24777/#review22323

::: mobile/android/chrome/content/WebrtcUI.js:199
(Diff revision 1)
> +    let camera = false;

Does js make you miss java's type system? :)

r+, however I am under the impression that we were removing webrtc from fennec entirely. Is that no longer the plan?

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Allison Naaktgeboren :ally from comment #13)
> ::: mobile/android/chrome/content/WebrtcUI.js:199
> (Diff revision 1)
> > +    let camera = false;
> 
> Does js make you miss java's type system? :)

Yes, I do. And I just can't trust JavaScript. :) How would you write this?

> let camera;
> if (camera) {

Something like this?


(In reply to Allison Naaktgeboren :ally from comment #13)
> r+, however I am under the impression that we were removing webrtc from
> fennec entirely. Is that no longer the plan?

We have been discussing removing support for (the current version of) webapps. But I haven't heard that we want to remove WebRTC. Isn't this the technology behind Firefox Hello?

Comment 15

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/8631642ebfaadd102d1eff42cba06107924dc7b8
Bug 1191741 - Family friendly browsing: Restrict sharing of camera and microphone with websites. r=ally

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8631642ebfaa

Comment 17

[u549602]

Verified as fixed on latest Nightly (45.0a1 2015-11-22).
Tested on Sony Xperia Z2 Android 5.0.2 
The following sites were accessed : https://apprtc.appspot.com and http://mozilla.github.com/webrtc-landing/gum_test.html

Comment 18

[Barbara Bermes [:barbara] - NI please!]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 19

[Barbara Bermes [:barbara] - NI please!]

Add toggle to disable sharing of camera and microphone in admin UI for family friendly browsing

Comment 20

[Sebastian Kaspari (:sebastian; :pocmo)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 21

[u549602]

Verified as fixed on latest Beta build (45.0b1) on a Sony Xperia Z2 with Android 5.0.2
You can see the test-plan that was used in testing this feature: https://wiki.mozilla.org/QA/Fennec/Control_video/audio_interaction_in_FFB

Comment 22

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with Barbara's wording.