1191872 - Move annotations to org.mozilla.gecko.annotation package

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

The Java convention is having a separate package for annotations (e.g. java.lang.annotation, android.annotation, etc.)

Bug 1191161 is moving WrapElementForJNI to org.mozilla.gecko.annotation.

In addition, we have JNITarget, RobocopTarget, and WebRTCJNITarget that are in org.mozilla.gecko.mozglue right now but should be moved to org.mozilla.gecko.annotation.

Comment 1

[Mark Capella [:capella]]

Attachment: bug1191872.diff

Crank it out :-)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb74e31fffd5

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8645310 [details] [diff] [review]
bug1191872.diff

Review of attachment 8645310 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

::: mobile/android/base/util/NativeJSContainer.java
@@ +4,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  package org.mozilla.gecko.util;
>  
> +import org.mozilla.gecko.annotation.JNITarget;

You can remove this since JNITarget is not used in NativeJSContainer.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/11024b678090

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11024b678090