Closed Bug 1191874 Opened 9 years ago Closed 9 years ago

gcli command 'cookie list' throws exception

Categories

(DevTools :: Framework, defect)

Product:
DevTools
Component:
Framework
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: ckerschb, Assigned: ochameau)

References

Details

Attachments

(1 file)

Fix typo if cookie gcli command
954 bytes, patch
jwalker
: review+
Details | Diff | Splinter Review
It seems that most (if not all) gcli commands are affected. It worked yesterday, so maybe a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1188401#c13 which landed last night. See stack underneath: ************************* A coding exception was thrown in a Promise resolution callback. See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise Full message: TypeError: this.conn._transport is null Full stack: Front<.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1162:9 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 Promise.prototype.then@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:451:5 Front<.send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1160:7 Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1180:5 frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1330:14 addLocalFunctions/</commandSpec.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:348:16 Requisition.prototype.exec/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2073:16 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:239:18 Task_spawn@resource://gre/modules/Task.jsm:164:12 exports.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/host.js:72:10 Requisition.prototype.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2072:14 Inputter.prototype._handleReturn@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:561:12 Inputter.prototype.handleKeyUp@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:460:1 Inputter.prototype.onKeyUp@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:432:3 EventListener.handleEvent*Inputter@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:55:3 DeveloperToolbar.prototype.show/this._showPromise</</</<@resource:///modules/devtools/DeveloperToolbar.jsm:424:27 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 Front<.onPacket/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1228:9 DevTools RDP*Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1178:7 frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1330:14 syncItems@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:313:10 exports.connectFront@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:296:10 exports.getSystem/links.promise</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/index.js:152:16 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 TabTarget_makeRemote/attachConsole/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:446:9 DebuggerClient.prototype.attachConsole/<@resource://gre/modules/devtools/dbg-client.jsm:586:7 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 DebuggerClient.prototype.attachConsole@resource://gre/modules/devtools/dbg-client.jsm:576:5 TabTarget_makeRemote/attachConsole@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:438:1 TabTarget_makeRemote/attachTab/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:433:9 DebuggerClient.prototype.attachTab/<@resource://gre/modules/devtools/dbg-client.jsm:504:7 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 DebuggerClient.prototype.attachTab@resource://gre/modules/devtools/dbg-client.jsm:498:5 TabTarget_makeRemote/attachTab@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:426:7 TabTarget_makeRemote/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:455:11 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 listenerJson@resource://gre/modules/devtools/dbg-client.jsm:759:9 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 RootClient.prototype.getTab@resource://gre/modules/devtools/dbg-client.jsm:1599:12 DebuggerClient.prototype.getTab@resource://gre/modules/devtools/dbg-client.jsm:471:39 TabTarget_makeRemote/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:452:9 DebuggerClient.prototype.connect/<@resource://gre/modules/devtools/dbg-client.jsm:408:9 eventSource/aProto.addOneTimeListener/l@resource://gre/modules/devtools/dbg-client.jsm:137:7 eventSource/aProto.emit@resource://gre/modules/devtools/dbg-client.jsm:194:9 this.DebuggerClient/<@resource://gre/modules/devtools/dbg-client.jsm:286:5 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:1042:9 LocalDebuggerTransport.prototype.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:569:11 ************************* Front.prototype.send threw an exception: TypeError: this.conn._transport is null Stack: Front<.send/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1162:9 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 Promise.prototype.then@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:451:5 Front<.send@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1160:7 Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1180:5 frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1330:14 addLocalFunctions/</commandSpec.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:348:16 Requisition.prototype.exec/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2073:16 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:239:18 Task_spawn@resource://gre/modules/Task.jsm:164:12 exports.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/host.js:72:10 Requisition.prototype.exec@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/cli.js:2072:14 Inputter.prototype._handleReturn@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:561:12 Inputter.prototype.handleKeyUp@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:460:1 Inputter.prototype.onKeyUp@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:432:3 EventListener.handleEvent*Inputter@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/mozui/inputter.js:55:3 DeveloperToolbar.prototype.show/this._showPromise</</</<@resource:///modules/devtools/DeveloperToolbar.jsm:424:27 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 Front<.onPacket/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1228:9 DevTools RDP*Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1178:7 frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1330:14 syncItems@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:313:10 exports.connectFront@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/system.js:296:10 exports.getSystem/links.promise</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/index.js:152:16 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 TabTarget_makeRemote/attachConsole/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:446:9 DebuggerClient.prototype.attachConsole/<@resource://gre/modules/devtools/dbg-client.jsm:586:7 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 DebuggerClient.prototype.attachConsole@resource://gre/modules/devtools/dbg-client.jsm:576:5 TabTarget_makeRemote/attachConsole@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:438:1 TabTarget_makeRemote/attachTab/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:433:9 DebuggerClient.prototype.attachTab/<@resource://gre/modules/devtools/dbg-client.jsm:504:7 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 DebuggerClient.prototype.attachTab@resource://gre/modules/devtools/dbg-client.jsm:498:5 TabTarget_makeRemote/attachTab@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:426:7 TabTarget_makeRemote/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:455:11 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 listenerJson@resource://gre/modules/devtools/dbg-client.jsm:759:9 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DevTools RDP*DebuggerClient.prototype.request@resource://gre/modules/devtools/dbg-client.jsm:743:5 RootClient.prototype.getTab@resource://gre/modules/devtools/dbg-client.jsm:1599:12 DebuggerClient.prototype.getTab@resource://gre/modules/devtools/dbg-client.jsm:471:39 TabTarget_makeRemote/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:452:9 DebuggerClient.prototype.connect/<@resource://gre/modules/devtools/dbg-client.jsm:408:9 eventSource/aProto.addOneTimeListener/l@resource://gre/modules/devtools/dbg-client.jsm:137:7 eventSource/aProto.emit@resource://gre/modules/devtools/dbg-client.jsm:194:9 this.DebuggerClient/<@resource://gre/modules/devtools/dbg-client.jsm:286:5 emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9 emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38 Request.prototype.emit@resource://gre/modules/devtools/dbg-client.jsm:1226:29 DebuggerClient.prototype.onPacket/emitReply@resource://gre/modules/devtools/dbg-client.jsm:1037:29 DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:1042:9
Alexandre, do you think that might be a regression from Bug 1188401?
Blocks: 1188401
Flags: needinfo?(poirot.alex)
May be, but it is not obvious. The typical regression is related to Loader.jsm/require. We should have seen a "devtools.require" is undefined exception or something related to Loader. But I landed various other patches...
Flags: needinfo?(poirot.alex)
May be bug 1190909, there is some patch against gcli? Have you tried reverting by any chance?
I do not see any such breakage/exception in today's build. I'm hitting this typo, which prevent printing a better exception in the console if the page doesn't have any cookie. Otherwise I'm seeing exception when using e10s. cookie command doesn't work at all when e10s is turned on, but it's not a regression, it never worked. When e10s is turned on, you get the following exception: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/cookie.js :: <TOP_LEVEL> :: line 13" data: no] Stack: @resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/cookie.js:13:10
Attachment #8645737 - Flags: review?(jwalker) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #4) > I do not see any such breakage/exception in today's build. After pulling the latest code from mozilla central the problem disappeared for me as well. I don't know what fixed it to make it work again. Thanks Alexandre for checking though.
https://hg.mozilla.org/mozilla-central/rev/41525423455f
Assignee: nobody → poirot.alex
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: