1191886 - async-scrollbar-1-vh[-rtl] reftests fail on Linux R-e10s with APZ enabled

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Of the various reftests failures in bug 1178359, the two async-scrollbar-1-vh* failures are because of rounding error. The vertical scrollbar is repositioned in the compositor and the computations just so happen to end up one pixel off from the main-thread computation. I changed the y-scroll amount from 10000px to 8000px and it seemed to fix the problem for the -rtl test, it will probably do the same for the non-rtl one. (isolation try push with logging at [1])

I don't think this rounding error is something that's worth fixing perfectly; the intent of the test case is just to make sure the compositor is repositioning the scrollbar to the right spot and being one pixel off doesn't matter so much. I'll just change the y-scroll amount instead.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=efbb1724c604

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This should do it. Confirmation try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=fda88e1601c2

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3e18ec3cae

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e3e18ec3cae