Closed Bug 1191886 Opened 6 years ago Closed 6 years ago

async-scrollbar-1-vh[-rtl] reftests fail on Linux R-e10s with APZ enabled

Categories

(Core :: Panning and Zooming, defect)

All
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Of the various reftests failures in bug 1178359, the two async-scrollbar-1-vh* failures are because of rounding error. The vertical scrollbar is repositioned in the compositor and the computations just so happen to end up one pixel off from the main-thread computation. I changed the y-scroll amount from 10000px to 8000px and it seemed to fix the problem for the -rtl test, it will probably do the same for the non-rtl one. (isolation try push with logging at [1])

I don't think this rounding error is something that's worth fixing perfectly; the intent of the test case is just to make sure the compositor is repositioning the scrollbar to the right spot and being one pixel off doesn't matter so much. I'll just change the y-scroll amount instead.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=efbb1724c604
Attachment #8644440 - Flags: review?(botond)
Attachment #8644440 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/5e3e18ec3cae
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.