1191893 - Make use of --update-allow-mar-channel for Firefox update tests

Status: RESOLVED WONTFIX

(Release Engineering :: Release Automation: Other, defect, P5)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The following request has not been implemented on bug 1148546 and therefore needs a separate bug.

Beta users get updated to a RC build and have to be brought back to a beta build. Therefore we need --update-allow-mar-channel

Lets say a beta user was on 38.0b9 and got updated to 38.0RC. This RC build is on the release channel, but beta users have to be brought back to beta channel. Given that we currently cannot test updates in multiple steps vXb9 -> RC -> v(X+1)b1, we have to run vXb9 -> RC, and RC -> v(X+1)b1 separately. Using the RC build as source build only allows the release mar channel. The option above can also enable the beta channel via update-settings.ini.

./firefox-ui-update --installer %Firefox38.0% --update-target-version=39.0b1 --update-target-buildid=%whateveritwillbe% --update-allow-mar-channel=firefox-mozilla-beta

This is a blocker for us until we can stop running the update tests via Mozmill/Marionette ourselves.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just tested with the update script and the parameter is correctly being forwarded. So this bug is simply the fact that we have to set the option when calling the firefox_ui_updates.py script. Maybe we should always set firefox-mozilla-release or firefox-mozilla-beta depending on which version we test?

Comment 2

[Armen [:armenzg]]

You're right.
I can't answer if there would be a case where we would not want to.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Robert, would you see any issue with my proposal in comment 1?

Comment 4

[Robert Kaiser]

It sounds good but note that this is lower priority to me than getting the Firefox UI Update tests to run on par with what we currently run via mozmill - and we do not run tests for this full case yet (only for beta users updating *to* RC builds, not away from them).

This is a gap we should fill in the future, though.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Huh, since when do we not test RC -> next beta? I always thought that this is part of your test plan given the importance that we do not loose beta people on the release channel.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The whole project here hasn't been finished and the already landed code is about to get removed.