1191902 - Non-blurred favicon tiles look bad on older iPads

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Brian Nicholson (:bnicholson)]

Older iPads don't support blur, and we simply show a stretched favicon as the top sites tile background, which looks pretty terrible. Maybe we could use the dominant color, or just a plain gray for v1?

Screenshot: https://www.dropbox.com/s/15z653w24iwjnsb/mail.google.com.png?dl=0

Comment 1

[Darrin Henein [:darrin]]

I thought the default behaviour for UIVisualEffect was to render a grey screen[1], which I don't see here... Steph do you have any idea why this isnt happening?

[1] http://stackoverflow.com/questions/24129167/uivisualeffectview-renders-differently-on-different-devices

Comment 2

[Brian Nicholson (:bnicholson)]

Yeah -- we intentionally changed that behavior in bug 1161258. What we do is look for all devices that don't support blur, and then we remove the blur for those devices.

Comment 3

[Stephan Leroux [:sleroux]]

Yup looks like we don't add a visual effect view at all when blur isn't supported:

https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Widgets/ThumbnailCell.swift#L116

Comment 4

[Darrin Henein [:darrin]]

Hmm, seems that https://bugzilla.mozilla.org/show_bug.cgi?id=1161258 was supposed to replace only the panel background with a flat color, not *every* instance of the blur effect. The OS (generally) does a decent job of degrading, we should leverage that :/

Comment 5

[Bryan Munar (:bkmunar)]

Waiting on robin for her decision on what to do with the topsites.

Comment 6

[Robin Andersen [:tecgirl]]

at the very least we should have a fallback for the devices that can't support the blur, so let's add UIColor whiteColor to all of the affected backgrounds (page bg, tilesbg, etc).

Comment 7

[Richard Newman [:rnewman]]

Bryan, what's the scope of this, and how soon can you get it done?

Comment 8

[Bryan Munar (:bkmunar)]

Attachment: The ui-review is more important, code can be changed. look at github picture and test code (remember to negate the isBlurSupported() to test on simulator)

Comment 9

[Darrin Henein [:darrin]]

Robin, happy with how the title bar loses it's definition on the white background? Not sure it looks right to me...

https://cloud.githubusercontent.com/assets/8356717/9189049/489f045a-3f98-11e5-955b-5ce54744f35b.png

Comment 10

[Aaron Train [:aaronmt]]

See this on an iPad Air/3/2

Comment 11

[Luna Jernberg]

Got this problem on my 4S with build 31 http://i.imgur.com/n4oKRJ4.png 
tough @rnewman said its already fixed in next build :)

Comment 12

[Robin Andersen [:tecgirl]]

(In reply to Darrin Henein [:darrin] from comment #9)
> Robin, happy with how the title bar loses it's definition on the white
> background? Not sure it looks right to me...
> 
> https://cloud.githubusercontent.com/assets/8356717/9189049/489f045a-3f98-
> 11e5-955b-5ce54744f35b.png

Tiles have been fixed, other blur issues addressed in bug 1193067.

Comment 13

[Richard Newman [:rnewman]]

5c49889