119192 - Add accesskeys to Recipient widget

Status: VERIFIED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Robert Kieffer]

The To/Cc/Bcc control only responds to up/down arrow keys.  It should also
respond to "t" to select "To:", "c" to select "Cc:", "b" to select "Bcc:", etc.

Comment 1

[Håkan Waara]

In other words, we need to add accesskeys (and as a side note, we're still 
awaiting the checkin of the big patch to implement true accesskey support).

->Composition

Comment 2

[Håkan Waara]

UI stuff goes to Varada, correct?

Comment 3

[Jean-Francois Ducarroz]

right, Varada takes care of the front-end of message compose...

Comment 4

[Sheela Ravindran]

change qa contact to olga

Comment 5

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 6

[Christian Wenz]

added access keyword.

Comment 7

[Christian Wenz]

Attachment: adds accesskey support for To/Cc/Bcc/...

The attached patch adds the access keys. This is still not the same behavior as
in Netscape 4: there, tabbing to the To/Cc/Bcc control and then pressing the
associated key suffices; here, you first have to press the down arrow to expand
the list, then use the associated key.

Comment 8

[Mike Cowperthwaite]

Comment on attachment 148727 [details] [diff] [review]
adds accesskey support for To/Cc/Bcc/... 

Chrisitan Wenz, you have to specify someone to take the review when you request
it.

Comment 9

[[e-mail]]

Since this bug was filed, bug 92491 was fixed which allows use of the first
letter without an access key and bug 64157 was fixed which allows use of letters
without opening the menulist first. This makes the recipient widget accessible.

Comment 10

[[e-mail]]

Comment on attachment 148727 [details] [diff] [review]
adds accesskey support for To/Cc/Bcc/... 

Patch is no longer necessary as per previous comment.

Comment 11

[Mike Cowperthwaite]

*** Bug 144303 has been marked as a duplicate of this bug. ***

Comment 12

[Thomas Brown]

It's *almost* fixed.  The only quibble I have is that the accelerator keys work
on a "cumulative" basis rather than a single keypress.  For instance, if you
type "B" to change the field to "Bcc", and then change your mind a few times by
hitting "T" for "To", "B" for "Bcc", etc., the selection will eventually no
longer change.  An accelerator key should be a unique, non-cumulative single
keypress, and should probably show up with the accelerator key underlined (just
as the pull-down menus have their hot key letters underlined).

Comment 13

[Mike Cowperthwaite]

(In reply to comment #12)
> The only quibble I have is that the accelerator keys work
> on a "cumulative" basis rather than a single keypress.

See bug 64157 for the design discussion, such as it was, about that feature.
Note that there is a timer, so if you stop typing for a second, the "cumulative 
buffer" clears and the next character typed is the first.

Comment 14

[Christian Wenz]

doesn't work for me with the released 1.7.8 version on various Windows platforms
(I am on the road right now and cannot test current builds and other systems).
Can someone verify?

Comment 15

[Mike Cowperthwaite]

(In reply to comment #14)
> doesn't work for me with the released 1.7.8 version on various Windows
> platforms

That's because the fix is in the trunk -- you need to be running a 1.8xxx build.
The fix will *not* be ported to 1.7.x.