1191925 - UI was frozen for ~10 seconds when I first signed into Sync

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Chris Peterson [:cpeterson]]

When I first signed into Sync and hit "Sync Now", the browser UI was unresponsive to any taps. The UI would correctly change between portrait and landscape orientation when I rotated my phone.

I am testing an iPhone 6 running iOS 8.4.

Comment 1

[Richard Newman [:rnewman]]

This is one of two things:

* Contention. Sync does a lot of work.
* A bug with the Sync Now button that causes it to block on the sync completing.

That shouldn't be the case:

            profile.syncManager.syncEverything().uponQueue(dispatch_get_main_queue()) { result in
                if result.isSuccess {
                    self.log.debug("Sync succeeded.")
                } else {
                    self.log.debug("Sync failed.")
                }
            }
            dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 3 * Int64(NSEC_PER_SEC)), dispatch_get_main_queue(), { () -> Void in
                cell.textLabel?.attributedText = self.syncNowTitle
                cell.userInteractionEnabled = true
            })

but running with the debugger should make this obvious.

Comment 2

[Stephan Leroux [:sleroux]]

Will profile this to see what's happening on the main thread

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/906

Comment 4

[Richard Newman [:rnewman]]

Comment on attachment 8646532 [details] [review]
https://github.com/mozilla/firefox-ios/pull/906

Ship it!

Comment 5

[Stephan Leroux [:sleroux]]

Ship-ped!