1192064 - |mach artifact| fails trying to package Android x86 builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

We don't export geckolibs and geckoview AAR files under x86 builds.  There's no particular reason not to.  The error is unhelpful, and *late* in the process (in |mach package|):

...
 0:00.79 Warning: /home2/mozilla-central/mobile/android/installer/package-manifest.in:618: Missing file(s): bin/crashreporter-override.ini
 0:00.79 Warning: /home2/mozilla-central/mobile/android/installer/package-manifest.in:622: Missing file(s): bin/chrome/icons/
 0:00.81 Warning: /home2/mozilla-central/mobile/android/installer/package-manifest.in:641: Missing file(s): bin/components/Sidebar.js
 0:00.81 Warning: /home2/mozilla-central/mobile/android/installer/package-manifest.in:653: Missing file(s): bin/components/SafeBrowsing.jsm
 0:02.19 /home2/android/android-ndk-r10e/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/i686-linux-android-strip: Unable to recognise the format of the input file `../../../dist/fennec/lib/x86/libmozglue.so'
 0:02.19 Traceback (most recent call last):
 0:02.19   File "/home2/mozilla-central/toolkit/mozapps/installer/packager.py", line 407, in <module>
 0:02.19     main()
 0:02.19   File "/home2/mozilla-central/toolkit/mozapps/installer/packager.py", line 403, in main
 0:02.19     copier.copy(args.destination)
 0:02.19   File "/home2/mozilla-central/python/mozbuild/mozpack/copier.py", line 323, in copy
 0:02.19     if f.copy(destfile, skip_if_older):
 0:02.19   File "/home2/mozilla-central/python/mozbuild/mozpack/files.py", line 267, in copy
 0:02.19     strip(dest)
 0:02.19   File "/home2/mozilla-central/python/mozbuild/mozpack/executables.py", line 100, in strip
 0:02.19     errors.fatal('Error executing ' + ' '.join(cmd))
 0:02.19   File "/home2/mozilla-central/python/mozbuild/mozpack/errors.py", line 103, in fatal
 0:02.19     self._handle(self.FATAL, msg)
 0:02.19   File "/home2/mozilla-central/python/mozbuild/mozpack/errors.py", line 98, in _handle
 0:02.19     raise ErrorMessage(msg)
 0:02.19 mozpack.errors.ErrorMessage: Error: Error executing /home2/android/android-ndk-r10e/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/i686-linux-android-strip ../../../dist/fennec/lib/x86/libmozglue.so
 0:02.21 make[3]: *** [stage-package] Error 1
 0:02.21 make[3]: Leaving directory `/home2/mozilla-central/obj-i386-linux-android/mobile/android/installer'
 0:02.21 make[2]: *** [make-package] Error 2
 0:02.21 make[2]: Leaving directory `/home2/mozilla-central/obj-i386-linux-android/mobile/android/installer'
 0:02.21 make[1]: *** [default] Error 2
 0:02.21 make[1]: Leaving directory `/home2/mozilla-central/obj-i386-linux-android/mobile/android/installer'
 0:02.21 make: *** [package] Error 2
 0:02.21 make: Leaving directory `/home2/mozilla-central/obj-i386-linux-android'

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1192064 - Add 'android-x86' job to |mach artifact|. r?jonalmeida

Bug 1192064 - Add 'android-x86' job to |mach artifact|. r?jonalmeida

Comment 2

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8678301 [details]
MozReview Request: Bug 1192064 - Add 'android-x86' job to |mach artifact|. r?jonalmeida

https://reviewboard.mozilla.org/r/23169/#review20641

Tested this locally. `mach package` and `mach install` now works on x86 devices!

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/48711da1e0658f9b533e2e45f50b9e90199016c5
Bug 1192064 - Add 'android-x86' job to |mach artifact|. r=jonalmeida

https://hg.mozilla.org/integration/fx-team/rev/599cddea4a027034f05a3b99c8050c592a7241c8
Bug 1192064 - Determine |mach artifact| job from mozconfig. r=me

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48711da1e065
https://hg.mozilla.org/mozilla-central/rev/599cddea4a02