1192156 - IME related structs, classes and enums defined in nsIWidget.h should be separated to different header

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, the head of nsIWidget.h has a lot of structs, classes and enum definition and implementation. That makes the nsIWidget definition lower. So, this is not good thing. We should move them into another header file. I think that it should be widget/IMEData.h and exported as mozilla/(widget/)IMEData.h.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa2b60ca3405

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5740e2063311

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Separate IME specific structs, classes and enums from nsIWidget.h to IMEData.h

The new header file steals about 700 lines from nsIWidget!

I wonder, we can move remaining two classes too. Then, we can make the new header name as mozilla/WidgetData.h or something. If you like this approach better, let me know. But I'm not sure if it's necessary since except IME specific, there are not so many lines (if we don't include the macros which define some constant values).

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8645270 [details] [diff] [review]
Separate IME specific structs, classes and enums from nsIWidget.h to IMEData.h

Review of attachment 8645270 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think you need Olli for this.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Looking good anyhow

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/dbeadce8cb5fe539691e5ac88e7aec3e31df9102
changeset:  dbeadce8cb5fe539691e5ac88e7aec3e31df9102
user:       Masayuki Nakano <[e-mail]>
date:       Sun Aug 09 00:47:19 2015 +0900
description:
Bug 1192156 Separate IME specific structs, classes and enums from nsIWidget.h to IMEData.h r=roc

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dbeadce8cb5f