1192197 - Product detail (or it ship-it replacement) should also list the RC releases into firefox_history_development_releases.json

Status: NEW

(www.mozilla.org :: Product Details, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

For now, we don't add them into the list, we should have this info into the list of the dev releases.

We should also do an import of all RC releases on the beta channel

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Maybe in ship-it, we should add a new field "shipped_pn_the_beta_channel" for the RC.
shipped_at would be for the release channel
and the new one for the release channel

therefor, we should be able to have the rc1 on both beta & release json files

Comment 2

[Sylvestre Ledru [:Sylvestre]]

wdyt guys?

Comment 3

[Johan Lorenzo [:jlorenzo]]

Having a filed "shipped_on_the_beta_channel_at" looks good to me, at a first glance. I'm not too familiar with the tables schema, but we may end up with ±9/10 entries which will have null for this field.
If that's a problem, maybe we could create a new table that lists what releases went through beta, at what time.
Otherwise, let's go for adding the field only.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I am proposing an easy solution, I don't mind waiting if we want to refactor to avoid a crappy workaround :)

Comment 5

[Rail Aliiev [:rail]]

I think we all agree that the schema requires some refactoring. I'd rather do this as a part of ship-it v2.

Adding a new column shouldn't be a big deal for now. We should also automate this similar to bug 1288434 - whenever we enable beta updates, we should automatically mark it as "shipped to beta".

Comment 6

[Rail Aliiev [:rail]]

Maybe we should explicitly list channels we published a build, including test channels. So there will be no special case for betas/release/esr/etc. So instead of using "shipped" we'd use a list of channel and publishedAt time stamps mappings.

Comment 7

[Rémy Hubscher (:natim)]

I need to detect when a RC has been released into the beta channel for the delivery dashboard [0]
Do you know of any ways I could get this information?

[0] https://mozilla.github.io/delivery-dashboard/
[1] Refs https://github.com/mozilla/PollBot/issues/111

Comment 8

[Sylvestre Ledru [:Sylvestre]]

An idea:
you scan that
http://ftp.mozilla.org/pub/firefox/candidates/56.0-candidates/
if the version > LATEST_FIREFOX_VERSION from https://product-details.mozilla.org/1.0/firefox_versions.json, this is an rc

this isn't perfect but better than what we have currently

Comment 9

[Rémy Hubscher (:natim)]

Ok I can probably come up with a Buildhub query for that then :) Thank you for the tip.